The study of genetic polymorphisms has touched every aspect of pulmonary and critical care medicine. We review recent progress made using genetic polymorphisms to define pathophysiology, to identify persons at risk for pulmonary disease and to predict treatment response. Several pitfalls are commonly encountered in studying genetic polymorphisms, and this article points out criteria that should be applied to design high-quality genetic polymorphism studies.