Organic carbon (OC) and elemental carbon (EC) in PM2.5 samples collected in urban (Xujiahui) and industrial (Baoshan) areas in Shanghai during 2007-2008 were analyzed with a DRI carbon analyzer using IMPROVE-TOR protocol. The results showed that the seasonal average concentrations of OC and EC were highest in the winter and lowest in the summer. The annual average concentrations of OC and EC were 8.10 and 3.91 microg x m(-3) at the urban sampling site, and 11.91 and 4.69 microg x m(-3) in the industrial area. The annual average OC/EC ratios at the two sites were 2.01 and 2.42, respectively. Strong correlations (R2 0.52-0.87) between OC and EC were found in all seasons, with the highest correlation coefficients in the winter ( R2 0.87 and 0.80) and the lowest in the spring (R2 0.52 and 0.58), indicating that the pollutant sources in spring was more complicated due to the varying wind directions. The annual average concentrations of secondary organic carbon (SOC) were 2.72 and 5.07 microg x m(-3) at the urban and industrial sites, accounting for about 30% of the total OC. The contribution of SOC to OC was the highest (about 40%) in the summer, in accordance with the high temperature and strong solar radiation in the summer. It was also found that precipitation had significant impact on the concentrations of OC and EC, especially in the winter. The average concentrations during periods without precipitation were two times higher than that during periods with precipitation in the winter, whereas no significant difference was found between the concentrations of OC and EC in the periods with and without precipitation in the summer, possibly due to the more stable atmospheric conditions during the periods with precipitation in comparison with those without precipitation. The OC/EC and SOC/OC ratios decreased significantly during precipitation.