Google Git
Anmelden
chromium / chromium / src / bda2e4ca17f249a3778a26724d94b2eaabc51d49
commitbda2e4ca17f249a3778a26724d94b2eaabc51d49[log] [tgz]
authorTom Van Goethem <[email protected]>Tue Jan 16 15:04:42 2024
committerChromium LUCI CQ <[email protected]>Tue Jan 16 15:04:42 2024
tree0e4b84e621a5950fba24b3a02c87779a33e7d5e1
parent8bd5c6f0b527c04f1cef5e119129f90e8cfdb07c [diff]
[M121] Reland "[SHv2] Dismiss notification when visiting PWM or extensions manager"

Relanding after revert with a fix for failing ChromeOS test. The fix is
just enabling the Safety Hub feature of the test.

Original change's description:
> Revert "[SHv2] Dismiss notification when visiting PWM or extensions manager"
>
> This reverts commit 5bb3e1e715431ee7c7125d5071de9b80f26d4395.
>
> Reason for revert:
> `ExtensionsActivityLogTest.TestSafetyHubMenuNotificationDismissed` is
> failing on linux-chromeos-chrome
> https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/37796/overview
>
> Original change's description:
> > [SHv2] Dismiss notification when visiting PWM or extensions manager
> >
> > With this CL, menu notification for the passwords and extensions module
> > of Safety Hub are dismissed when either the password manager page or
> > extensions manager page are visited.
> >
> > Bug: 1443466, 1500955
> > Change-Id: I9aa5d5410d6c1ef681ee5b94fdc8af347377dad4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5053765
> > Code-Coverage: [email protected] <[email protected]>
> > Reviewed-by: Devlin Cronin <[email protected]>
> > Commit-Queue: Tom Van Goethem <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1236556}
>
> Bug: 1443466, 1500955
> Change-Id: Ic8e0ad66f9ebeede3b166edf03f93ba8ac074378
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5117079
> Owners-Override: Mikihito Matsuura <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Auto-Submit: Mikihito Matsuura <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1236687}

(cherry picked from commit 98aeb966346dae99dcad236c34d076bbf11b1f0c)

Bug: 1443466, 1500955
Change-Id: Ia9e7970e7459487755a98d02482cb8d5e0e34165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5130987
Reviewed-by: Kelvin Jiang <[email protected]>
Commit-Queue: Tom Van Goethem <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Reviewed-by: Side YILMAZ <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1243653}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5180526
Cr-Commit-Position: refs/branch-heads/6167@{#1394}
Cr-Branched-From: 222e786949e76e342d325ea0d008b4b6273f3a89-refs/heads/main@{#1233107}
15 files changed
tree: 0e4b84e621a5950fba24b3a02c87779a33e7d5e1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. intern
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.