Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation key EoL #18

Öffnen Sie
ezYakaEagle442 opened this issue Oct 29, 2022 · 1 comment
Öffnen Sie

Instrumentation key EoL #18

ezYakaEagle442 opened this issue Oct 29, 2022 · 1 comment
Assignees
Labels
Enhancement New feature or request Tracking Triaging The issue is during triaging, will be prioritized

Kommentare

@ezYakaEagle442
Copy link

ezYakaEagle442 commented Oct 29, 2022

Is your feature request related to a problem? Please describe.
azureSpringAppsMonitoringSettings required to use the AppInsights Instrumentation key :

resource azureSpringAppsMonitoringSettings 'Microsoft.AppPlatform/Spring/monitoringSettings@2022-09-01-preview' = {
  name: monitoringSettingsName
  parent: azureSpringApps
  properties: {
    appInsightsInstrumentationKey: appInsights.properties.InstrumentationKey
    appInsightsSamplingRate: 10
    // traceEnabled: true Indicates whether enable the trace functionality, which will be deprecated since api version 2020-11-01-preview. Please leverage appInsightsInstrumentationKey to indicate if monitoringSettings enabled or not
  }
}

But https://learn.microsoft.com/en-us/azure/azure-monitor/app/java-in-process-agent#set-the-application-insights-connection-string states :

On March 31, 2025, support for instrumentation key ingestion will end. Instrumentation key ingestion will continue to work, but we'll no longer provide updates or support for the feature. Transition to connection strings to take advantage of new capabilities.

Describe the solution you'd like
ASA should be updated accordingly, this will impact all customers with potential outage, having to create new ASA service instances.

The sooner this change is implemented, the better it is as it would impact less customers.

Describe alternatives you've considered
N/A

Additional context
N/A

@ezYakaEagle442 ezYakaEagle442 added the Enhancement New feature or request label Oct 29, 2022
@domainname domainname self-assigned this Jan 19, 2023
@allxiao allxiao added the Triaging The issue is during triaging, will be prioritized label Jan 19, 2023
@domainname
Copy link

domainname commented May 25, 2023

We are planning to

  1. Issue a warning when users pass instrumentation key in Azure CLI.
  2. Update Azure Spring Apps docs accordingly, in which we would recommend to use connection string.

A few more things are still pending for discussion. Will update this thread later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Tracking Triaging The issue is during triaging, will be prioritized
Projects
None yet
Development

No branches or pull requests

3 participants