Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled report windows #46

Closed
jinghao opened this issue May 27, 2020 · 2 comments
Closed

Scheduled report windows #46

jinghao opened this issue May 27, 2020 · 2 comments

Comments

@jinghao
Copy link
Contributor

jinghao commented May 27, 2020

Hi @csharrison and @michaelkleber !

A few weeks ago, we discussed the default attribution windows of 2 days, 7 days and (a configurable window up to 30 days). You mentioned that you only wanted the last window to be configurable, and wanted to keep the first two fixed.

I mentioned that 1-day and 7-days would be much more useful because it's much more common to have 1-day attribution windows in reporting products than 2-days.

@csharrison mentioned that the 2-day window was arbitrary and would be open to revising it, and suggested we discuss here, so here I am! I'd love to understand whether you have any concerns with replacing the default 2-day window with a 1-day window and how to make progress on this.

Thanks!

@csharrison
Copy link
Collaborator

Maybe the best option here is to allow more flexibility to configure multiple windows. If the impressionexpiry implicitly determines the end window, it might make sense to have another field called something like earlyreporttimes which allows you to specify the other windows:

earlyreporttimes="86400000,604800000"

We would probably want to have something like day rounding to ensure that each window defines a period that is at least a day.

@johnivdel FYI for thoughts.

@akashnadan
Copy link
Collaborator

Moving discussion to #730 and closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants