Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image closing tags #144

Merged
merged 1 commit into from
Mar 19, 2015
Merged

Conversation

frederfred
Copy link
Contributor

This PR removes unvalid tags

There is a bug in the current version of the Cloudinary gem that occurs when using dpr oder responsive options with the cloudinary image tag helper

<%= cl_image_tag 'sample.jpg', dpr: :auto %>

outputs

<img data-src="http://res.cloudinary.com/demo/image/upload/dpr_auto/sample.jpg" class="cld-hidpi"></img>

Images are self closing, and the use of tag instead of content_tag fixes that.

@tocker tocker merged commit 3558278 into cloudinary:master Mar 19, 2015
tocker added a commit that referenced this pull request Mar 22, 2015
  * Added Video Support
    * `cl_video_tag` creates an HTML video tag with optionally inner `source` tags
    * `cl_video_path` provides a url to the video resource
    * `cl_video_thumbnail_tag` creates an `img` tag with a video thumbnail and
    * `cl_video_thumbnail_path` provides a url to the video resource's thumbnail
  * Added `:zoom` transformation parameter
  * Applied Pull Requests:
    * Fix image closing tags #144
    * Fix callback path. #138
  * Update Cloudinary's jQuery plugin to v1.0.22.
  * Update .gitignore file
@frederfred frederfred deleted the fix/closing-img-tag branch May 7, 2015 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants