-
Benachrichtigungen
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): add support for cloud storage subscriptions #7977
Merged
hongalex
merged 16 commits into
googleapis:main
from
hongalex:feat-pubsub-storage-subscriptions
Jun 23, 2023
Merged
feat(pubsub): add support for cloud storage subscriptions #7977
hongalex
merged 16 commits into
googleapis:main
from
hongalex:feat-pubsub-storage-subscriptions
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-pubsub-storage-subscriptions
shollyman
reviewed
Jun 1, 2023
lahuang4
reviewed
Jun 15, 2023
lahuang4
approved these changes
Jun 16, 2023
shollyman
approved these changes
Jun 21, 2023
@@ -617,6 +620,14 @@ func (s *GServer) UpdateSubscription(_ context.Context, req *pb.UpdateSubscripti | |||
} | |||
} | |||
|
|||
case "cloud_storage_config": | |||
sub.proto.CloudStorageConfig = req.GetSubscription().GetCloudStorageConfig() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's some invariant here that ensures req.GetSubscription() doesn't return nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, it's checked in the first lines above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the Pub/Sub API.
size: l
Pull request size is large.
stale: old
Pull request is old and needs attention.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for subscriptions that pushes messages to Cloud Storage.