Maniphest T234017

Protect log entries offer link to change protection only to unprivileged users
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Sep 27 2019, 8:36 AM

Tags

Referenced Files

None

Subscribers

Description

When I view https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Logbuch?type=protect&user=&page=&wpdate=&tagfilter= logged out, I see links to change the protection for every entry. When I view it logged in as sysop, these links are missing.
And indeed, https://phabricator.wikimedia.org/rMW7b4eafda0d986180d20f37f2489b70e8eca00df4#change-rrHPZ8dxSYkt accidentally negated the permission check.

Details

	Subject	Repo	Branch	Lines +/-
	Fix permission check on protection log	mediawiki/core	master	+43 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW7b4eafda0d98: Replace usages of deprecated User::isAllowed. Step 2.

Event Timeline

Schnark created this task.Sep 27 2019, 8:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2019, 8:36 AM

Ammarpad claimed this task.Sep 27 2019, 1:20 PM

Ammarpad triaged this task as Medium priority.

Change 539536 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Fix permission check on protection log

https://gerrit.wikimedia.org/r/539536

gerritbot added a project: Patch-For-Review.Sep 27 2019, 1:47 PM

• Pchelolo closed this task as Resolved.Sep 27 2019, 4:43 PM

Change 539536 merged by jenkins-bot:
[mediawiki/core@master] Fix permission check on protection log

https://gerrit.wikimedia.org/r/539536

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 27 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2019, 7:10 PM