Page MenuHomePhabricator

Gray background FOUC on search icon
Closed, ResolvedPublic

Description

When I load any page (with Vector skin), the search icon next to the search box on the top right briefly shows with a gray background, and only after a short moment changes to white/transparent.
Given this is highly visible, I assume it must be a 1.35.0-wmf.1 regression, otherwise it would have been noticed before. https://www.mediawiki.org/wiki/MediaWiki_1.35/wmf.1#Vector lists several changes to styles that shouldn't have changed anything visibly, but might accidentally have.

Event Timeline

Confirming. background-color: transparent for #searchButton gets loaded quite late...

As far as I can see, the gray is the default background color for buttons, so depending on browser and OS the issue might not be visible. But for me this happens both with Firefox, Chromium, and Konqueror on Linux.

There are actually two buttons in the search form: the normal button you always thought was there, and a fallback button that leads to the full-text search, which is only active in no-JS mode (and it gets removed by JS code). The second button doesn't have background-color: transparent set.

Change 542959 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Vector@master] Apply transparent background to both search buttons

https://gerrit.wikimedia.org/r/542959

Change 542959 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Apply transparent background to both search buttons

https://gerrit.wikimedia.org/r/542959

Volker_E assigned this task to matmarex.
Volker_E triaged this task as Medium priority.