How should wikidata/structured data diffs appear on mobile?
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Jan 28 2020, 1:22 PM

Description

As noted in T243235 any change to wikidata value appears as a side by side diff in mobile.

https://commons.m.wikimedia.org/wiki/Special:MobileDiff/388741403
IT also appears like this on Wikidata: https://m.wikidata.org/wiki/Special:MobileDiff/1065024945

Screenshot_20200121-090348.png (480×960 px, 97 KB)

Screenshot_20200121-090309.png (480×960 px, 45 KB)

it's unclear if this has always been this way or is a recent regression as a result of upstreaming diff code from MobileFrontend to core.

Developer notes

MobileFrontend's Special:MobileDiff page now makes use of wikidiff2 to render diffs using DifferenceEngine in core.

The diff-type inline parameter is only supposed to work on content types that use TextSlotDiffRenderer. I'm not sure what SlotDiffRenderer this is using, but I'd hazard a guess it's got a custom diff renderer so won't support it. If this diff previously displayed differently in mobile this was likely not intentional.

Waiting on hearing back from StructuredData team about what's going on here as I don't have a knowledge of the inner workings of how these extensions work.

Possibly https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/tree/master/src/Diff is related?

Related Objects

Mentioned In: T243235: Regression: Desktop diff styles for moved paragraphs load alongside mobile
Mentioned Here: T243235: Regression: Desktop diff styles for moved paragraphs load alongside mobile

Event Timeline

Jdlrobson created this task.Jan 28 2020, 1:22 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 28 2020, 1:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Addshore have diffs on wikidata always looked like https://m.wikidata.org/wiki/Special:MobileDiff/1065024945 ? If not do you know anything about the innerworkings of thoses diffs and what's happened here?

Jdlrobson mentioned this in T243235: Regression: Desktop diff styles for moved paragraphs load alongside mobile.Jan 28 2020, 1:24 PM

Agabi10 subscribed.Jan 28 2020, 1:26 PM

Note following CSS provides a quick fix:

.diff-marker,
td:first-child {
  display: none;
}

.diff-addedline {
  display: block;
  width: 100%;
}

.diff-addedline {
  border: none;
  background: none;
}
.diff-addedline .diffchange, .diff-deletedline .diffchange {
  border-radius: 0;
}

https://m.wikidata.org/wiki/Special:MobileDiff/1065024945

Screen Shot 2020-01-28 at 9.33.19 PM.png (1×1 px, 161 KB)

Tgr subscribed.Feb 4 2020, 4:16 AM

Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.Feb 21 2020, 6:49 PM

• Sarahmarie1981 edited projects, added WMDE-Tech-Communication-Source-Code-Berlin; removed Structured-Data-Backlog.Mar 16 2020, 3:32 PM

Aklapper removed a project: WMDE-Tech-Communication-Source-Code-Berlin.Mar 16 2020, 4:11 PM

JJMC89 added a project: Structured-Data-Backlog.Mar 17 2020, 6:54 PM

CBogen moved this task from Triage to SDoC Statements on the Structured-Data-Backlog board.Aug 27 2020, 9:47 PM

Addshore unsubscribed.Jun 27 2023, 12:37 PM

These currently appear stacked:
https://commons.m.wikimedia.org/w/index.php?title=File:%D0%A4%D0%BE%D1%82%D0%BE_%D0%90%D0%BB%D0%B8%D1%88%D0%B5%D1%80_%D0%A2%D0%B0%D1%88%D0%BC%D0%B0%D1%82%D0%BE%D0%B2_%D0%91%D0%BE%D0%B3%D0%B0%D1%80%D0%B4%D0%B8%D0%B5%D0%B2%D0%B8%D1%87.jpg&diff=388741403&diffonly=1

Is this not correct?

Screenshot 2024-03-18 at 5.05.51 PM.png (998×1 px, 88 KB)

	F42737025: Screenshot 2024-03-18 at 5.05.51 PM.png
	Mar 19 2024, 12:22 AM

	F31536677: Screen Shot 2020-01-28 at 9.33.19 PM.png
	Jan 28 2020, 1:33 PM

	F31518826: Screenshot_20200121-090309.png
	Jan 28 2020, 1:22 PM

	F31518822: Screenshot_20200121-090348.png
	Jan 28 2020, 1:22 PM

How should wikidata/structured data diffs appear on mobile?Open, Needs TriagePublicActions

Description

Developer notes

Related Objects

Event Timeline

How should wikidata/structured data diffs appear on mobile?
Open, Needs TriagePublic
Actions