Page MenuHomePhabricator
Create Task
Maniphest T249030

Hard deprecate LockManagerGroup::singleton and remove a release later
Closed, ResolvedPublic
Actions

Description

LockManagerGroup::singleton is only used in fallback code for older versions and could be hard deprecated.
https://codesearch.wmflabs.org/search/?q=lockmanagergroup%5Cs*%3A%3A%5Cs*singleton&i=fosho&files=&repos=

LockManagerGroup::destroySingleton
https://codesearch.wmflabs.org/search/?q=lockmanagergroup%5Cs*%3A%3A%5Cs*destroySingleton&i=fosho&files=&repos=

Outstanding patch sets for remove deprecated code:
https://gerrit.wikimedia.org/r/#/q/topic:lockmanagergroup+(status:open+OR+status:merged)

Details

SubjectRepoBranchLines +/-
Remove LockManagerGroup::singleton() and ::destroySingletons()mediawiki/coremaster+14 -54
Hard deprecate LockManagerGroup::singleton() and ::destroySingletons()mediawiki/coremaster+26 -7
Customize query in gerrit

Event Timeline

Umherirrender created this task.Mar 31 2020, 6:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 6:10 PM
Zabe claimed this task.May 3 2021, 1:57 PM
Zabe added a project: User-Zabe.
Zabe subscribed.
gerritbot added a comment.May 3 2021, 2:39 PM

Change 684420 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecate LockManagerGroup::singleton()

https://gerrit.wikimedia.org/r/684420

gerritbot added a project: Patch-For-Review.May 3 2021, 2:39 PM
gerritbot added a comment.May 3 2021, 11:01 PM

Change 684420 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate LockManagerGroup::singleton() and ::destroySingletons()

https://gerrit.wikimedia.org/r/684420

Maintenance_bot removed a project: Patch-For-Review.May 3 2021, 11:10 PM
Zabe moved this task from Backlog to Deprecation on the User-Zabe board.May 6 2021, 10:52 AM
gerritbot added a comment.Sep 16 2021, 2:56 PM

Change 721557 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove LockManagerGroup::singleton() and ::destroySingletons()

https://gerrit.wikimedia.org/r/721557

gerritbot added a project: Patch-For-Review.Sep 16 2021, 2:57 PM
gerritbot added a comment.Sep 17 2021, 7:41 PM

Change 721557 merged by jenkins-bot:

[mediawiki/core@master] Remove LockManagerGroup::singleton() and ::destroySingletons()

https://gerrit.wikimedia.org/r/721557

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 17 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 17 2021, 8:10 PM
Zabe closed this task as Resolved.Sep 17 2021, 8:19 PM
Zabe removed a project: User-Zabe.Apr 13 2022, 1:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits