Page MenuHomePhabricator
Create Task
Maniphest T249061

Hard deprecate wfDiff() global function
Closed, ResolvedPublic
Actions

Description

The function has been soft deprecated since 1.25. Its only remaining callers are two maintenance scripts and ParserDiffTest.php according to this codesearch query.

Details

SubjectRepoBranchLines +/-
Remove global function wfDiff(), deprecated since 1.25 and unusedmediawiki/coremaster+1 -80
Hard-deprecate global function wfDiffmediawiki/coremaster+1 -0
Remove usages of global function wfDiff()mediawiki/coremaster+15 -8
Customize query in gerrit

Related Objects

Event Timeline

Ammarpad created this task.Mar 31 2020, 9:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 9:40 PM
Ammarpad renamed this task from Hard deprecate wfDiff global function to Hard deprecate wfDiff() global function.Mar 31 2020, 9:42 PM
Ammarpad updated the task description. (Show Details)
Ammarpad updated the task description. (Show Details)Mar 31 2020, 11:36 PM
gerritbot added a comment.Mar 31 2020, 11:36 PM

Change 585054 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove last remaining calls to wfDiff()

https://gerrit.wikimedia.org/r/585054

gerritbot added a project: Patch-For-Review.Mar 31 2020, 11:36 PM
Aklapper added a project: MediaWiki-General.Apr 1 2020, 11:02 AM

Adding MediaWiki-General as this seems to be about the MediaWiki Core codebase, so someone can find this task.

DannyS712 mentioned this in T249995: Create #mediawiki-global-scope.Apr 11 2020, 11:21 AM
DannyS712 edited projects, added MediaWiki-Page-diffs; removed MediaWiki-General.Apr 27 2020, 5:46 AM
gerritbot added a comment.Aug 19 2020, 9:58 AM

Change 621214 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Hard-deprecate global function wfDiff

https://gerrit.wikimedia.org/r/621214

gerritbot added a comment.Aug 19 2020, 10:26 AM

Change 585054 merged by jenkins-bot:
[mediawiki/core@master] Remove usages of global function wfDiff()

https://gerrit.wikimedia.org/r/585054

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 19 2020, 11:00 AM
gerritbot added a comment.Aug 19 2020, 3:13 PM

Change 621214 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate global function wfDiff

https://gerrit.wikimedia.org/r/621214

Ammarpad closed this task as Resolved.Aug 19 2020, 3:33 PM
Ammarpad claimed this task.
gerritbot added a comment.Jul 23 2021, 12:23 PM

Change 707330 had a related patch set uploaded (by Jforrester; author: Zabe):

[mediawiki/core@master] Remove global function wfDiff(), deprecated since 1.25 and unused

https://gerrit.wikimedia.org/r/707330

gerritbot added a comment.Jul 23 2021, 12:58 PM

Change 707330 merged by jenkins-bot:

[mediawiki/core@master] Remove global function wfDiff(), deprecated since 1.25 and unused

https://gerrit.wikimedia.org/r/707330

Zabe subscribed.Jul 23 2021, 1:00 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 23 2021, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits