mobile-html: mw:leadImage meta tag removes language information from SVG, causing the wrong language to be displayed in an SVG lead image in the apps
Closed, ResolvedPublicBUG REPORT
Actions

Description

Original report:

User has Android interface language set to German, but reports he always sees the SVG on the following page in English:

https://de.wikipedia.org/wiki/Amt_(Kommunalrecht)

Notes:
The mw:leadImage meta tag in mobile-html has the original SVG URL:
https://upload.wikimedia.org/wikipedia/commons/3/3b/Administrative_divisions_of_Germany.svg

The thumb URL for the image on the page is:
https://upload.wikimedia.org/wikipedia/commons/thumb/3/3b/Administrative_divisions_of_Germany.svg/langde-600px-Administrative_divisions_of_Germany.svg.png

It's possible PCS needs to use the language specific thumbnail for mw:leadImage, or the apps should be sending langde when constructing thumbnail URLs. CC @Tsevener @Dbrant to coordinate requirements

Details

Subject	Repo	Branch	Lines +/-
Pass `pilangcode` on PageImages request	mediawiki/services/mobileapps	master	+59 -1
Add language param in prop=pageimages API	mediawiki/extensions/PageImages	master	+42 -15
Add localized SVG on mw:leadImage	mediawiki/services/mobileapps	master	+49 -2

Customize query in gerrit

Related Objects

Duplicates Merged Here: T236523: Show incorrect SVG file in the app

Event Timeline

• Charlotte created this task.Jul 3 2020, 10:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2020, 10:21 PM

• Charlotte moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.Jul 3 2020, 11:19 PM

@Charlotte PI needs specific reproduction steps and/or screenshots, could you provide more details?

JoeWalsh renamed this task from SVG language not matching with interface language to mobile-html: mw:leadImage meta tag removes language information from SVG, causing the wrong language to be displayed in an SVG lead image in the apps.Jul 8 2020, 3:49 PM

JoeWalsh added a project: Page Content Service.

JoeWalsh updated the task description. (Show Details)

JoeWalsh added subscribers: Tsevener, Dbrant.

Dbrant merged a task: T236523: Show incorrect SVG file in the app.Jul 8 2020, 5:12 PM

Dbrant added a subscriber: cooltey.

LGoto triaged this task as Medium priority.Jul 15 2020, 3:44 PM

LGoto moved this task from Needs triage to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.

MSantos moved this task from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Aug 5 2020, 12:06 PM

MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

Jgiannelos claimed this task.Aug 5 2020, 3:16 PM

Jgiannelos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Change 618541 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/mobileapps@master] WIP: fix mw:leadImage URL

https://gerrit.wikimedia.org/r/618541

gerritbot added a project: Patch-For-Review.Aug 5 2020, 3:27 PM

Change 618541 abandoned by Jgiannelos:
[mediawiki/services/mobileapps@master] Add localized SVG on mw:leadImage

Reason:
Implement the language logic in PageImages extension

https://gerrit.wikimedia.org/r/618541

Change 620703 had a related patch set uploaded (by Jgiannelos; owner: Jgiannelos):
[mediawiki/extensions/PageImages@master] Add language param in prop=pageimages API

https://gerrit.wikimedia.org/r/620703

Change 620703 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Add language param in prop=pageimages API

https://gerrit.wikimedia.org/r/620703

Change 621261 had a related patch set uploaded (by Jgiannelos; owner: Jgiannelos):
[mediawiki/services/mobileapps@master] Pass pilangcode on PageImages request

https://gerrit.wikimedia.org/r/621261

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 19 2020, 2:00 PM

Jgiannelos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 20 2020, 11:28 AM

Change 621261 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Pass pilangcode on PageImages request

https://gerrit.wikimedia.org/r/621261

Jgiannelos moved this task from Code Review to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 1 2020, 3:34 PM