Deprecate Skin::getSearchLink
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 14 2020, 10:17 PM

Description

We should be moving away from this.

In doing so we will also need to deprecate the searchaction SkinTemplate key, by checking the parameter in SkinTemplate::text and throwing a warning when searchaction is provided as a parameter.

https://codesearch.wmcloud.org/search/?q=searchaction&i=nope&files=&repos=

There is only one usage in production in CologneBlue - that can use SpecialPage::getTitleFor( 'Search' )->getLocalURL(); directly.

Details

Subject	Repo	Branch	Lines +/-
Deprecate Skin::getSearchLink	mediawiki/core	master	+10 -1
Replace usage of Skin::getSearchLink	mediawiki/skins/Nostalgia	master	+2 -1
Replace usage of Skin::getSearchLink	mediawiki/skins/CologneBlue	master	+3 -1

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 14 2020, 10:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 10:17 PM

Jdlrobson moved this task from Phase 3 - standardise template data to Phase 2 - Deprecate and remove Skin methods for readability on the MediaWiki-Core-Skin-Architecture board.Jul 15 2020, 8:47 PM

Change 621110 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/CologneBlue@master] Replace usage of Skin::getSearchLink

https://gerrit.wikimedia.org/r/621110

gerritbot added a project: Patch-For-Review.Aug 19 2020, 2:09 AM

Change 621111 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Nostalgia@master] Replace usage of Skin::getSearchLink

https://gerrit.wikimedia.org/r/621111

Change 621112 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin::getSearchLink

https://gerrit.wikimedia.org/r/621112

Ammarpad added a project: Nostalgia.Aug 19 2020, 2:24 AM

Change 621110 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Replace usage of Skin::getSearchLink

https://gerrit.wikimedia.org/r/621110

Change 621111 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Replace usage of Skin::getSearchLink

https://gerrit.wikimedia.org/r/621111

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 19 2020, 9:00 PM

Ammarpad claimed this task.Aug 20 2020, 9:30 AM

Change 621112 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin::getSearchLink

https://gerrit.wikimedia.org/r/621112