Page MenuHomePhabricator

TimedMediaHandler: PHP Notice: Undefined offset: 1
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

exception.class ErrorException

MediaWiki version: 1.36.0-wmf.1

message
PHP Notice: Undefined offset: 1
exception.trace
#0 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/handlers/OggHandler/File_Ogg/File/Ogg/Media.php(133): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/handlers/OggHandler/File_Ogg/File/Ogg/Vorbis.php(286): File_Ogg_Media->_decodeBareCommentsHeader()
#2 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/handlers/OggHandler/File_Ogg/File/Ogg/Vorbis.php(172): File_Ogg_Vorbis->_decodeCommentsHeader(integer, integer)
#3 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/handlers/OggHandler/File_Ogg/File/Ogg.php(480): File_Ogg_Vorbis->__construct(integer, array, resource)
#4 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/handlers/OggHandler/File_Ogg/File/Ogg.php(207): File_Ogg->_splitStreams()
#5 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/handlers/OggHandler/OggHandler.php(17): File_Ogg->__construct(string)
#6 /srv/mediawiki/php-1.36.0-wmf.1/includes/filerepo/file/UnregisteredLocalFile.php(193): OggHandler->getMetadata(UploadStashFile, string)
#7 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/handlers/OggHandler/OggHandler.php(155): UnregisteredLocalFile->getMetadata()
#8 /srv/mediawiki/php-1.36.0-wmf.1/includes/media/MediaHandler.php(448): OggHandler->getImageSize(UploadStashFile, string)
#9 /srv/mediawiki/php-1.36.0-wmf.1/includes/filerepo/file/UnregisteredLocalFile.php(123): MediaHandler->getPageDimensions(UploadStashFile, integer)
#10 /srv/mediawiki/php-1.36.0-wmf.1/includes/filerepo/file/UnregisteredLocalFile.php(134): UnregisteredLocalFile->cachePageDimensions(integer)
#11 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/TimedMediaHandler.php(353): UnregisteredLocalFile->getWidth()
#12 /srv/mediawiki/php-1.36.0-wmf.1/extensions/TimedMediaHandler/includes/TimedMediaHandler.php(149): TimedMediaHandler->isAudio(UploadStashFile)
#13 /srv/mediawiki/php-1.36.0-wmf.1/includes/api/ApiQueryImageInfo.php(355): TimedMediaHandler->normaliseParams(UploadStashFile, array)
#14 /srv/mediawiki/php-1.36.0-wmf.1/includes/api/ApiQueryImageInfo.php(292): ApiQueryImageInfo->checkParameterNormalise(UploadStashFile, array)
#15 /srv/mediawiki/php-1.36.0-wmf.1/includes/api/ApiQueryStashImageInfo.php(63): ApiQueryImageInfo->mergeThumbParams(UploadStashFile, array, string)
#16 /srv/mediawiki/php-1.36.0-wmf.1/includes/api/ApiQuery.php(263): ApiQueryStashImageInfo->execute()
#17 /srv/mediawiki/php-1.36.0-wmf.1/includes/api/ApiMain.php(1593): ApiQuery->execute()
#18 /srv/mediawiki/php-1.36.0-wmf.1/includes/api/ApiMain.php(529): ApiMain->executeAction()
#19 /srv/mediawiki/php-1.36.0-wmf.1/includes/api/ApiMain.php(500): ApiMain->executeActionWithErrorHandling()
#20 /srv/mediawiki/php-1.36.0-wmf.1/api.php(90): ApiMain->execute()
#21 /srv/mediawiki/php-1.36.0-wmf.1/api.php(45): wfApiMain()
#22 /srv/mediawiki/w/api.php(3): require(string)
#23 {main}

Impact

Notes

Reportedly fixed before at T230158.

Details

Request ID
d374e3c9-bd7b-4717-aadf-fa7ed6c52a7b
Request URL
https://commons.wikimedia.org/w/api.php?action=query&format=json&prop=stashimageinfo&siifilekey=17nj5bxma99g.d8wb6t.9529722.ogx&siiprop=url&siiurlwidth=120&siiurlheight=120&errorformat=html&errorlang=en&errorsuselocal=1&formatversion=2

Event Timeline

Change 628852 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TimedMediaHandler@master] Fix ?? guard for broken Ogg Vorbis comments

https://gerrit.wikimedia.org/r/628852

Change 628852 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix ?? guard for broken Ogg Vorbis comments

https://gerrit.wikimedia.org/r/628852

Krinkle updated the task description. (Show Details)
Krinkle edited Stack Trace. (Show Details)

Looks fixed from the patch sets. Please have a look if this is still in the logs. Thanks.