Page MenuHomePhabricator

SkinMustache should provide raw data for rendering a footer
Closed, ResolvedPublic

Description

Currently SkinMustache requires all skins to manage their own code for footer generation.

All skins replicate the same logic and historically this has led to inconsistencies in markup e.g. T259401.

As we move more production skins onto SkinMustache I'd like to see these patterns generalized and generate via the same functions in SkinMustache

Skin developers will be able to render info, icons and places in different locations within the skin (e.g. notably CologneBlue) but they should always carry the same HTML markup.

Event Timeline

Change 626793 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Expose footer data in SkinMustache

https://gerrit.wikimedia.org/r/626793

Change 630913 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Prefer local data to parent data

https://gerrit.wikimedia.org/r/630913

Change 630913 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Prefer local data to parent data (attempt 2)

https://gerrit.wikimedia.org/r/630913

Change 626793 merged by jenkins-bot:
[mediawiki/core@master] Expose footer data in SkinMustache

https://gerrit.wikimedia.org/r/626793