Page MenuHomePhabricator

Exception thrown when Citoid tool opened in CX: TypeError: cxData is undefined
Closed, ResolvedPublic

Description

at ve.dm.CXReferenceNode.prototype.onAttach URL1:508:619
at OO.EventEmitter.prototype.emit URL2:223:483
at ve.Node.prototype.attach URL3:26:463
at ve.dm.BranchNode.prototype.splice URL3:90:21
at splice URL3:156:908
at ve.dm.TreeModifier.static.applyTreeOperation URL3:160:830
at ve.dm.TreeModifier.static.applyTreeOperations URL3:156:162
at ve.dm.TreeModifier.prototype.process URL3:162:101
at ve.dm.TransactionProcessor.prototype.process URL3:108:41
at ve.dm.Document.prototype.commit URL3:230:626
at ve.dm.Surface.prototype.changeInternal URL3:191:489
at ve.dm.Surface.prototype.change URL3:191:1
at ve.dm.SurfaceFragment.prototype.change URL3:201:416
at ve.dm.SurfaceFragment.prototype.insertContent URL3:211:940
at ve.dm.MWReferenceModel.prototype.insertReferenceNode URL1:53:897
at ve.ui.CitoidInspector.prototype.getSetupProcess/< URL1:93:421
at proceed/< URL2:521:96
at mightThrow URL2:110:149
at resolve/</process< URL2:110:808

URL1: https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.CodeMirror.visualEditor%7Cext.CodeMirror.visualEditor.init%7Cext.abuseFilter.visualEditor%7Cext.cite.styles%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%7Cext.confirmEdit.CaptchaInputWidget%2CvisualEditor%7Cext.disambiguator.visualEditor%7Cext.geshi.visualEditor%7Cext.graph.data%2CvisualEditor%7Cext.kartographer%7Cext.kartographer.editing%2Cutil%2CvisualEditor%7Cext.math.styles%2CvisualEditor%7Cext.score.visualEditor%7Cext.score.visualEditor.icons%7Cext.spamBlacklist.visualEditor%7Cext.templateDataGenerator.editPage%7Cext.titleblacklist.visualEditor%7Cext.visualEditor.data%2CmoduleIcons%2CmoduleIndicators%7Cext.wikihiero.visualEditor%7Cext.wikimediaEvents.visualEditor%7Cjquery.throttle-debounce%7Cmediawiki.ForeignStructuredUpload%2CForeignUpload%2CUpload%7Cmediawiki.ForeignStructuredUpload.BookletLayout%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.language.names%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CStashedFileWidget%2CTable%2CUserInputWidget%7Cmediawiki.widgets.DateInputWidget.styles%7Cmoment%7Cmw.cx.visualEditor%7Cmw.cx.visualEditor.base%2Ccontent%2Clink%2Cmt%2CpublishSettings%2Csection%2Csentence%7Coojs-ui.styles.icons-editing-citation%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-layout%2Cicons-location%2Cicons-media%2Cicons-moderation%2Cicons-movement&skin=vector&version=qgdlb
URL2: https://fr.wikipedia.org/w/load.php?lang=fr&modules=diffMatchPatch%2Cdompurify%2Cjquery%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Csite%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.cx.eventlogging.campaigns%7Cext.cx.model%2Cutil%7Cext.cx.widgets.spinner%7Cext.cx.wikibase.link%7Cext.echo.api%2Cinit%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.common%2Ccompactlinks%2Cinit%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery.client%2Ccookie%2Ctablesorter%2CtextSelection%7Cjquery.tablesorter.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cdeflate%2Cexperiments%2CjqueryMsg%2Clanguage%2Cpulsatingdot%2Cstorage%2Cuser%2Cutil%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.action.view.redirectPage%7Cmediawiki.editfont.styles%7Cmediawiki.interface.helpers.styles%7Cmediawiki.language.months%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.ui.button%7Cmediawiki.widgets.styles%7Cmw.cx.MachineTranslation%2CMwApiRequestManager%2CSiteMapper%2Cdm%2Cinit%2Cui%2Cutil%7Cmw.cx.dm.PageTitleModel%2CTranslation%2CTranslationIssue%2CWikiPage%7Cmw.cx.init.Translation%7Cmw.cx.tools.IssueTrackingTool%2CTranslationTool%2CTranslationToolFactory%7Cmw.cx.ui.Categories%2CCategoryMultiselectWidget%2CHeader%2CInfobar%2CMessageWidget%2CPageTitleWidget%2CPersonalMenuWidget%2CTranslationToolWidget%2CTranslationView%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-accessibility%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-interactions%2Cicons-user%2Cicons-wikimedia%2Cindicators%7Cskins.vector.js%7Cuser.defaults%7Cve.ce.CXLintableNode%7Cve.dm.CXLintableNode%7Cve.init.mw.CXTarget%7Cve.ui.CXDesktopContext%2CCXSurface&skin=vector&version=8bf8j
URL3: https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.visualEditor.base%2Ccore%2Cdiffing%2Cmediawiki%2Cmwcore%2Cmwlink%2Cmwmeta%2CprogressBarWidget%2Csanitize%2CsupportCheck%2Cswitching%2CtargetLoader%2CtempWikitextEditorWidget%2Ctrack%2Cve%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.core.utils.parsing%7Cext.visualEditor.desktopArticleTarget.init&skin=vector&version=1rise

Event Timeline

Verified that I get an exception whenever I click the "Cite" button in CX.

Esanders renamed this task from TypeError: cxData is undefined to Exception thrown when Citoid tool opened in CX: TypeError: cxData is undefined .Sep 18 2020, 1:46 PM

I can replicate the issue:
Steps:
1-start a translation
2-translate a paragraph
3-select a word from the translated part
4-select the "Cite" option from the editing bar

image.png (410×1 px, 81 KB)

5-create a reference
image.png (346×1 px, 72 KB)

Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.

Based on the initial investigation this is no breaking the ability for users to add citations. Keeping it as a low priority for a code cleanup task, since errors should not be polluting the console anyways.

Change 631520 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] CXReferenceNode: Ensure getAdaptationInfo always returns an object

https://gerrit.wikimedia.org/r/631520

Change 631520 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CXReferenceNode: Ensure getAdaptationInfo always returns an object

https://gerrit.wikimedia.org/r/631520

matmarex assigned this task to Esanders.
matmarex subscribed.

(the task was removed from the team workboard so I'm going to just close it, should be resolved by the patch)