Page MenuHomePhabricator
Create Task
Maniphest T263445

Gap caused by floated image after a reference has been changed
Closed, ResolvedPublic
Actions

Description

Presumably caused by a clear CSS property being set somewhere in the reference list:

image.png (588×1 px, 186 KB)

Steps

  1. Open https://en.wikipedia.org/wiki/Aston_Martin_Bulldog?veaction=edit at ~1200px wide
  2. Edit/delete/move a reference to cause the reflist to update
  3. Observe the big gap in the list

Details

SubjectRepoBranchLines +/-
Follow-up I673c28c2: Only apply clearfix to main content areamediawiki/skins/Vectormaster+4 -0
Turn off clearfix on MWPreviewElementmediawiki/extensions/VisualEditormaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

• Esanders created this task.Sep 21 2020, 11:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2020, 11:56 AM
• Esanders added a comment.Sep 21 2020, 12:01 PM

The cause is the clearfix on .mw-body-content. I think we should disable that by default for preview elements. If a specific preview element needs a clearfix it can add it back in.

gerritbot added a comment.Sep 21 2020, 12:03 PM

Change 628784 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Turn off clearfix on MWPreviewElement

https://gerrit.wikimedia.org/r/628784

gerritbot added a project: Patch-For-Review.Sep 21 2020, 12:03 PM
• Esanders moved this task from To Triage to Triaged on the VisualEditor board.Sep 21 2020, 12:03 PM
• Esanders added a project: Editing-team (Kanban Board).
• Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
• Esanders mentioned this in T254195: Implement a core 'clearfix' mixin in mediawiki.mixin and evaluate deprecation/removal of 'visualClear' class.Sep 21 2020, 12:13 PM

Turns out this is a regression caused by T254195, so we might be able to fix upstream instead.

gerritbot added a comment.Sep 21 2020, 12:24 PM

Change 628789 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/Vector@master] Follow-up I673c28c2: Only apply clearfix to main content area

https://gerrit.wikimedia.org/r/628789

gerritbot added a comment.Sep 21 2020, 12:25 PM

Change 628784 abandoned by Esanders:
[mediawiki/extensions/VisualEditor@master] Turn off clearfix on MWPreviewElement

Reason:
Fixed upstream in Vector instead: I693cd3d4d32501a2a4ab20140a662943fba22bb6

https://gerrit.wikimedia.org/r/628784

• Esanders added a project: Desktop Improvements (Vector 2022).Sep 21 2020, 12:26 PM
gerritbot added a comment.Sep 21 2020, 10:04 PM

Change 628789 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Follow-up I673c28c2: Only apply clearfix to main content area

https://gerrit.wikimedia.org/r/628789

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 21 2020, 11:00 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 1 2020, 9:16 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
JTannerWMF edited projects, added Skipped QA; removed Editing QA.Nov 23 2020, 7:49 PM
JTannerWMF moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Nov 24 2020, 3:05 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 24 2020, 3:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits