Page MenuHomePhabricator
Create Task
Maniphest T264533

Image gets empty 'alt' attribute when changed
Closed, ResolvedPublic
Actions

Description

  1. Open an existing image on a page
  2. Select "Change image" and replace it with image
  3. Go to the wikitext diff in the save dialog, observe |alt=| has been added.

Details

SubjectRepoBranchLines +/-
Don't set alt text if attribute was originally 'null'mediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Esanders created this task.Oct 4 2020, 4:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2020, 4:12 PM
gerritbot added a comment.Oct 4 2020, 4:37 PM

Change 631980 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't set alt text if attribute was originally 'null'

https://gerrit.wikimedia.org/r/631980

gerritbot added a project: Patch-For-Review.Oct 4 2020, 4:37 PM
• Esanders mentioned this in T257581: Visual Editor adds link= parameter to image when only caption is edited.Oct 4 2020, 4:38 PM
matmarex added a project: Editing-team (Kanban Board).Oct 6 2020, 12:10 AM
• Esanders removed a project: Editing-team (Kanban Board).Oct 6 2020, 12:11 AM
• Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Oct 6 2020, 12:29 AM

Change 631980 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't set alt text if attribute was originally 'null'

https://gerrit.wikimedia.org/r/631980

matmarex added a project: Editing-team (Kanban Board).Oct 6 2020, 12:32 AM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
matmarex subscribed.

(no idea how you managed to remove the task from the workboard and simultaneously move it to a different column on that workboard)

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 6 2020, 1:00 AM
• Esanders added a comment.Oct 6 2020, 1:01 PM

This should be testable on the beta cluster.

• Esanders moved this task from To Triage to Triaged on the VisualEditor board.Oct 6 2020, 10:31 PM
JTannerWMF edited projects, added Skipped QA; removed Editing QA.Nov 23 2020, 7:45 PM
JTannerWMF moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Nov 25 2020, 6:04 AM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 25 2020, 6:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits