Replace html paragraph tags in i18n
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

As follow up to T254946: HTML escaping bug in RevisionSlider tutorial we should remove the HTML in the tutorial message and use linebreaks and wikitext parsing instead.

Change the message as follows.
Make sure it looks the same as before (see the screenshot below for reference). If the resulting HTML uses <p> or <br><br> doesn't matter.

revisionslider-help-dialog-slide3a

<p>To compare certain revisions, select the revisions using the two colored knobs.</p><p>The upper knob controls the newer revision, the lower knob maps to the older revision.</p><p>Move the knobs by drag and drop or clicking on the slider line.</p>

To compare certain revisions, select the revisions using the two colored knobs.\n\nThe upper knob controls the newer revision, the lower knob maps to the older revision.\n\nMove the knobs by drag and drop or clicking on the slider line.

Screenshot from 2022-02-07 15-05-43.png (287×351 px, 24 KB)

Details

Other Assignee: abhigya_pandey

	Subject	Repo	Branch	Lines +/-
	Replace html paragraph tags in i18n	mediawiki/extensions/RevisionSlider	master	+3 -2

Customize query in gerrit

Related Objects

Mentioned In: T301060: "Other Language" hyperlink is missing in wikipedia.org.
Mentioned Here: T254946: HTML escaping bug in RevisionSlider tutorial

Event Timeline

WMDE-Fisch created this task.Nov 3 2020, 1:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2020, 1:23 PM

WMDE-Fisch moved this task from Proposed to Maintenance Backlog on the WMDE-TechWish board.Nov 3 2020, 1:23 PM

WMDE-Fisch added a project: MediaWiki-extensions-Maintenance (by Skizzerz).

thiemowmde removed a project: MediaWiki-extensions-Maintenance (by Skizzerz).Nov 4 2020, 8:40 AM

thiemowmde added a project: good first task.Feb 7 2022, 2:12 PM

thiemowmde updated the task description. (Show Details)

thiemowmde set the point value for this task to 1.

thiemowmde moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.

Is this issue still open?
if Yes,Can I work on it?
This is my very first contribution I need some guidance. I want to work on this issue. Please help me get started.
@WMDE-Fisch @Aklapper

thiemowmde subscribed.Feb 17 2022, 1:53 PM

Mohdabbas955 mentioned this in T301060: "Other Language" hyperlink is missing in wikipedia.org..Feb 17 2022, 3:28 PM

@Mohdabbas955: Please read https://www.mediawiki.org/wiki/New_Developers#Some_general_communication_tips - thanks a lot.

Change 771512 had a related patch set uploaded (by Abhigya Pandey; author: Abhigya Pandey):

[mediawiki/extensions/RevisionSlider@master] Replace html paragraph tags in i18n

https://gerrit.wikimedia.org/r/771512

gerritbot added a project: Patch-For-Review.Mar 17 2022, 7:02 AM

Hi, @Aklapper, @WMDE-Fisch and @thiemowmde I tried to solve this issue and made a PR please review it and suggest the required changes needed to solve this issue.

(@abhigya_pandey: Thanks. There was a notification in this very task; six minutes before your comment. Plus Gerrit notifications. No need for triplication.)

Hi, thiemowmde I have uploaded patch set 2 with the necessary changes please review it and give your feedback.

Hello,
How can we view any particular installed extension in our local environment of Wikimedia.
We can see the list of installed extension by going to the Special:Version page but what I want is that how we can see subpages of any particular extension in local after installing it.
By going to which route we can view changes done by myself in code base of particular extension in localhost.

Not all extensions have a subpage. RevisionSlider can be found by opening the history of any page and clicking any of the diff links. RevisionSlider appears as a small bar at the top, which can be expanded. The message in this ticket can be see by clicking the question mark icon.

Thank you @thiemowmde for your nice explanation.

abhigya_pandey claimed this task.Mar 23 2022, 1:22 PM

thiemowmde updated Other Assignee, added: abhigya_pandey.Mar 24 2022, 10:48 AM

thiemowmde added projects: WMDE-TechWish-Sprint-2022-03-16, Unplanned-Sprint-Work.

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-03-16 board.

thiemowmde moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-03-16 board.Mar 28 2022, 1:17 PM

thiemowmde moved this task from Incoming to Done on the Revision-Slider board.

Change 771512 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Replace html paragraph tags in i18n

https://gerrit.wikimedia.org/r/771512

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 28 2022, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 28 2022, 2:10 PM