Page MenuHomePhabricator
Create Task
Maniphest T277334

Deprecate the UserLoadFromDatabase hook
Closed, ResolvedPublic
Actions

Description

I propose that the UserLoadFromDatabase hook be removed - it is currently unused, and removing it would simplify the eventual migration to creating user objects on foreign wikis. Th first step would be hard deprecation in 1.37

Details

SubjectRepoBranchLines +/-
Hard deprecate UserLoadFromDatabase hookmediawiki/coremaster+5 -1
Customize query in gerrit

Event Timeline

DannyS712 created this task.Mar 12 2021, 7:14 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 12 2021, 7:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Later on the User-DannyS712 board.Mar 12 2021, 7:14 PM
• Pchelolo subscribed.Mar 15 2021, 12:54 AM

Sounds good. Not used indeed and IMHO the hook is way too intrusive

• AMooney edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Mar 16 2021, 2:09 PM
• AMooney moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.
• AMooney triaged this task as Medium priority.Mar 16 2021, 2:31 PM
gerritbot added a comment.May 1 2021, 1:28 AM

Change 683958 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Hard deprecate UserLoadFromDatabase hook

https://gerrit.wikimedia.org/r/683958

gerritbot added a project: Patch-For-Review.May 1 2021, 1:28 AM
gerritbot added a comment.May 1 2021, 3:21 AM

Change 683958 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate UserLoadFromDatabase hook

https://gerrit.wikimedia.org/r/683958

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 1 2021, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 1 2021, 4:10 AM
DannyS712 renamed this task from Deprecate and remove UserLoadFromDatabase hook to Deprecate the UserLoadFromDatabase hook.May 1 2021, 7:06 PM
DannyS712 closed this task as Resolved.
DannyS712 claimed this task.
DannyS712 updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits