Page MenuHomePhabricator

When encountering an error, enable Update pagelist button in dialogue
Closed, ResolvedPublic

Description

When a user encounters an error after pressing the Update Pagelist button in Visual mode (maybe due to bad internet connectivity), he is forced to change the page numbering type to be able to use the Update pagelist button again to trigger a reload.

Screenshot from 2021-03-27 16-14-49.png (768×1 px, 203 KB)

When a error is encountered, enable the Update pagelist regardless of wether any changes have occured.

Documentation

Criteria

  • When the mainModel emits a parsing error, emit an event inside VisualDialogModel
  • Hook a function that set's the Update Pagelist button's state to enabled when the event is fired in VisualFormPanel.

Event Timeline

Change 678385 had a related patch set uploaded (by Sahilgrewalhere; author: Sahilgrewalhere):

[mediawiki/extensions/ProofreadPage@master] When encountering an error, enable Update pagelist button in dialogue

https://gerrit.wikimedia.org/r/678385

Change 678385 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] When encountering an error, enable Update pagelist button in dialogue

https://gerrit.wikimedia.org/r/678385

@Sahilgrewalhere: Hi, the patch in Gerrit has been merged. Can this task be resolved (via Add Action...Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!