⚓ T280803 Remove WikibaseClient constructor

	Subject	Repo	Branch	Lines +/-
	Make WikibaseClient constructor private	mediawiki/extensions/Wikibase	master	+4 -0
	Remove WikibaseClient constructor	mediawiki/extensions/Wikibase	master	+0 -155

Lucas_Werkmeister_WMDE created this task.Apr 21 2021, 3:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2021, 3:07 PM

This should probably wait for T280765: Remove WikibaseClient::getDefaultInstance().

Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Apr 21 2021, 10:15 PM

Rosalie_WMDE claimed this task.Apr 22 2021, 9:21 AM

Rosalie_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Change 681992 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove WikibaseClient constructor

https://gerrit.wikimedia.org/r/681992

gerritbot added a project: Patch-For-Review.Apr 22 2021, 2:54 PM

Rosalie_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 22 2021, 4:01 PM

Change 681992 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseClient constructor

https://gerrit.wikimedia.org/r/681992

ItamarWMDE closed this task as Resolved.Apr 23 2021, 7:26 AM

ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 23 2021, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2021, 8:10 AM

Reopening this, because the class now has a default constructor, which is public:

Psy Shell v0.10.5 (PHP 7.4.9 — cli) by Justin Hileman
>>> new Wikibase\Client\WikibaseClient()
=> Wikibase\Client\WikibaseClient {#3205}

It would be better to make the constructor private, so that it’s not possible to create a WikibaseClient instance. (Sorry for the confusing task title.)

Lucas_Werkmeister_WMDE claimed this task.Apr 26 2021, 10:36 AM

Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Lucas_Werkmeister_WMDE added a subscriber: Rosalie_WMDE.

Change 682582 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Make WikibaseClient constructor private

https://gerrit.wikimedia.org/r/682582

gerritbot added a project: Patch-For-Review.Apr 26 2021, 10:40 AM

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 26 2021, 10:40 AM

Change 682582 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make WikibaseClient constructor private

https://gerrit.wikimedia.org/r/682582

Rosalie_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.Apr 27 2021, 10:00 AM