Page MenuHomePhabricator

Default value for TranslateCacheDirectory in extension.json should be bool, not string
Closed, ResolvedPublicBUG REPORT

Description

--- a/extension.json
+++ b/extension.json
@@ -965,7 +965,7 @@
			"public": true
		},
		"TranslateCacheDirectory": {
-			"value": "false",
+			"value": false,
			"description": "Set location of cache files. Defaults to $wgCacheDirectory.",
			"public": true
		},

Otherwise, TranslateUtils::cacheFile() interprets the default value as a local directory named false, which probably was not intended, given the $wgTranslateCacheDirectory !== false check.

List of steps to reproduce (step by step, including full links if applicable):

  • Don't override TranslateCacheDirectory or $wgTranslateCacheDirectory.
  • Run processMessageChanges.php directly from the scripts directory, with some new changes to process.

What happens?:

The CDB files representing the change are created in a new scripts/false directory, and are invisible to Special:ManageMessageGroups.

What should have happened instead?:

CDB files should go into $wgCacheDirectory by default.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Translate at 1a8db6f, MediaWiki 1.35.2

Event Timeline

Nmlgc renamed this task from Default value for TranslateCacheDirectory should be bool, not string to Default value for TranslateCacheDirectory in extension.json should be bool, not string.Apr 27 2021, 1:35 PM
Nmlgc updated the task description. (Show Details)

Would you like to try submitting that patch to Gerrit? There is https://www.mediawiki.org/wiki/Gerrit_patch_uploader for example.

Change 682976 had a related patch set uploaded (by Nmlgc; author: Nmlgc):

[mediawiki/extensions/Translate@master] Change default value for TranslateCacheDirectory to bool

https://gerrit.wikimedia.org/r/682976

Urbanecm triaged this task as Medium priority.

Change 682976 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Change default value for TranslateCacheDirectory to bool

https://gerrit.wikimedia.org/r/682976

Change 682820 had a related patch set uploaded (by Urbanecm; author: Nmlgc):

[mediawiki/extensions/Translate@REL1_35] Change default value for TranslateCacheDirectory to bool

https://gerrit.wikimedia.org/r/682820

Change 682821 had a related patch set uploaded (by Urbanecm; author: Nmlgc):

[mediawiki/extensions/Translate@REL1_36] Change default value for TranslateCacheDirectory to bool

https://gerrit.wikimedia.org/r/682821

Change 682821 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_36] Change default value for TranslateCacheDirectory to bool

https://gerrit.wikimedia.org/r/682821

Change 682820 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_35] Change default value for TranslateCacheDirectory to bool

https://gerrit.wikimedia.org/r/682820