Maniphest T288712

Why are numerous Crypt functions static and called non statically?
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Aug 12 2021, 3:01 AM

Tags

Referenced Files

None

Subscribers

Description

The abstract class Crypt has numerous static functions, getTallyDescriptors, updateTallyContext, updateDbForTallyJob, cleanupDbForTallyJob, but then are called non statically $election->getCrypt()->updateDbForTallyJob( $electionId, $dbw, $data ); etc

Feels like they should be marked as not static... And possibly abstract too? But maybe not on the latter

Details

	Subject	Repo	Branch	Lines +/-
	Make GpgCrypt extend Crypt	mediawiki/extensions/SecurePoll	master	+21 -15

Customize query in gerrit

Related Objects

Mentioned Here: T271830: Allow election decryption key to be submitted via the TallyPage form
T277222: Create job to tally elections [M]
rESPO88a7b99fc5f9: Allow decrption key to be entered via tally page
rESPO0f53f751ad43: Create job to tally elections

Event Timeline

Reedy created this task.Aug 12 2021, 3:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2021, 3:01 AM

Added by rESPO88a7b99fc5f9: Allow decrption key to be entered via tally page for T271830: Allow election decryption key to be submitted via the TallyPage form and rESPO0f53f751ad43: Create job to tally elections for T277222: Create job to tally elections [M]

Change 711869 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/SecurePoll@master] Make GpgCrypt extend Crypt

https://gerrit.wikimedia.org/r/711869

gerritbot added a project: Patch-For-Review.Aug 12 2021, 3:27 AM

Change 711869 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Make GpgCrypt extend Crypt

https://gerrit.wikimedia.org/r/711869

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 12 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2021, 5:10 PM

@Reedy is this task good to close?

I think so!