Edit summary previews are no longer italic
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tacsipacsi
	Aug 15 2021, 12:59 PM

Description

Steps to reproduce

Open a page for editing, e.g. User talk:Tacsipacsi/sandbox.
Enter some edit summary.
Click Show preview or Show changes.
Look at the preview of the edit summary.

Actual result

The edit summary is not italic.

Expected result

The edit summary is shown in italic.

Additional information

New regression in 1.37.0-wmf.18.
Tested with Monobook, legacy and new Vector, other skins may be broken as well.
When fixing this, care should be taken to fix both the traditional, full page reload experience, and the AJAX-based live preview (T41272).

Details

	Subject	Repo	Branch	Lines +/-
	EditPage: load mediawiki.interface.helpers.styles	mediawiki/core	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T293045: Regression: Hidden file revisions are no longer styled
T287410: ResourceLoaderSkinModule: Skins should not use the legacy styling feature
Mentioned Here: T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery
T278576: Remove non-critical path interface styles out of legacy feature into more appropriate homes
rMWddbf011257fb: Move most remaining legacy styles to interface.helpers.styles
T41272: Bugs in "Live preview" feature (tracking)

Event Timeline

Tacsipacsi created this task.Aug 15 2021, 12:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2021, 12:59 PM

Tacsipacsi mentioned this in T287410: ResourceLoaderSkinModule: Skins should not use the legacy styling feature.Aug 15 2021, 12:59 PM

This regression is caused by rMWddbf011257fbe307d5ea3a583ccf5128fee3c2b0 (T278576), where the CSS style rule for span.comment was moved to interface.helpers.styles. These styles should also be loaded upon edit previewing. We failed to identify that usage, because the documentation for that style rule says Comment portions of RC entries.

Change 713074 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] EditPage: load mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/713074

gerritbot added a project: Patch-For-Review.Aug 15 2021, 2:01 PM

Mainframe98 moved this task from Backlog to Edit summary on the MediaWiki-Page-editing board.Aug 15 2021, 2:19 PM

I'm going to plug T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery here since the italics were also discussed in that task. (Feel free to fix the regression, just note that italics are bad for non-Latin script.)

Tacsipacsi renamed this task from Edit summary previews no longer italic to Edit summary previews are no longer italic.Aug 15 2021, 3:26 PM

Change 713074 merged by jenkins-bot:

[mediawiki/core@master] EditPage: load mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/713074

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 15 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2021, 6:10 PM

XanonymusX subscribed.Aug 15 2021, 9:32 PM

Ameisenigel subscribed.Aug 16 2021, 9:17 AM

The fix will be deployed to Wikimedia wikis this week, with the MediaWiki version 1.37.0-wmf.19, per the usual schedule (https://www.mediawiki.org/wiki/MediaWiki_1.37/Roadmap).

Umherirrender mentioned this in T293045: Regression: Hidden file revisions are no longer styled.Oct 13 2021, 7:28 PM

	F34596838: Screenshot_2021-08-15 Creating User talk Tacsipacsi sandbox - Wikipedia.png
	Aug 15 2021, 12:59 PM

	F34596840: Screenshot_2021-08-15 Creating User talk Tacsipacsi sandbox - Wikipedia(1).png
	Aug 15 2021, 12:59 PM

Edit summary previews are no longer italicClosed, ResolvedPublicBUG REPORTActions