Legacy parser generates different output on RTL wikis for left/right aligned images compared to LTR wkis but Parsoid does not
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ssastry
	Aug 20 2021, 3:12 AM

Description

Check output of this on ar.wikipedia.org and en.wikipedia.org

[[File:Hawk moth caterpillar.jpg|thumb|250px|Right|Hippotion celerio]]

On en.wikipedia.org, the legacy parser HTML looks like :<div class="thumb tright" ..> ... </div>
On ar.wikipedia.org, the legacy parser HTML looks like :<div class="thumb tleft" ..> ... </div>

But, Parsoid generates <figure class="mw-halign-right" ..>...</figure> in both cases.

Should Parsoid flip the left/right orientation in the HTML or should the CSS for the classes be transformed via CSSJanus? Right now, neither of this happens and causes pretty significant rendering diffs (which shows up in visual diff testing).

Details

	Subject	Repo	Branch	Lines +/-
	Bump parsoid to 0.14.0-a17	mediawiki/vendor	master	+207 -190
	Make magic words case-sensitive	mediawiki/services/parsoid	master	+38 -23

Customize query in gerrit

Related Objects

Mentioned Here: T259165: Make img_lossy case-sensitive like the rest of the img_ options

Event Timeline

• ssastry created this task.Aug 20 2021, 3:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2021, 3:12 AM

Arlolra closed this task as a duplicate of T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI.Aug 20 2021, 9:44 PM

Wait, maybe this isn't a dupe, since there's an explicit "right"

Oh, hmm, this is silly. Media options are supposed to be case sensitive but it doesn't look like Parsoid is. It probably was at some point, seeing T259165. I wonder what happened ...

Arlolra claimed this task.Aug 20 2021, 11:21 PM

Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Change 714145 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Media options are case sensitive

https://gerrit.wikimedia.org/r/714145

gerritbot added a project: Patch-For-Review.Aug 20 2021, 11:31 PM

Arlolra triaged this task as Medium priority.Aug 20 2021, 11:32 PM

Change 714145 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Make magic words case-sensitive

https://gerrit.wikimedia.org/r/714145

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2021, 4:10 AM

Arlolra closed this task as Resolved.Aug 24 2021, 3:01 PM