The search result box (for empty result) does not have the same height across different media types.
- Ensure that all mediaType have the same distance between filter and placeholder image
The image below show the difference between images and audio
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix: Search result box is not the same height across media types | mediawiki/extensions/MediaSearch | master | +22 -22 |
Event Timeline
Comment Actions
The issue is reproducible in FF and Chrome - below is the animated gif to illustrate the vertical "movement" of sdms-no-results__icon :
Comment Actions
.sdms-search-resultslist--video, .sdms-search-resultslist--image
needs to be changed from
margin: -8px;
to
margin: 0px -8px -8px -8px;
Comment Actions
Change 799256 had a related patch set uploaded (by MarkThisDot; author: MarkThisDot):
[mediawiki/extensions/MediaSearch@master] Fix: Search result box is not the same height across media types
Comment Actions
Change 799256 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@master] Fix: Search result box is not the same height across media types
Comment Actions
Checked in commons beta - the issue is fixed.
Checked in commons wmf.16 - the issue is not present anymore.