Page MenuHomePhabricator
Create Task
Maniphest T297287

More verbose / prettier output for PHPUnit
Closed, ResolvedPublic
Actions

Description

It would be nice to print out the classes that are being tested. For one thing, we'd be able to verify that the tests we think are running in CI are in fact being run. It would also be nice if the output is somewhat compact, so it's reasonable to run this locally and see an overview of what has run. So far I've found https://github.com/mikeerickson/phpunit-pretty-result-printer, open to other ideas. It doesn't work great with our phpunit.php wrapper, but in theory T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php will happen one day.

Details

SubjectRepoBranchLines +/-
phpunit: Don't output skipped tests in summarymediawiki/coremaster+47 -0
phpunit: Restore default progress reporter and add MWTestDox optionmediawiki/coremaster+48 -27
phpunit: Reintroduce plain result printermediawiki/coremaster+89 -24
phpunit: Use customized TestDox outputmediawiki/coremaster+33 -3
phpunit: Use codedungeon/phpunit-result-printer for plain phpunitmediawiki/coremaster+10 -2
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Dec 8 2021, 1:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2021, 1:36 PM
gerritbot added a comment.Dec 8 2021, 1:37 PM

Change 745246 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] phpunit: Use codedungeon/phpunit-result-printer for plain phpunit

https://gerrit.wikimedia.org/r/745246

gerritbot added a project: Patch-For-Review.Dec 8 2021, 1:37 PM
kostajh added a comment.Dec 8 2021, 1:39 PM

phpunit-pretty-result-printer:

grafik.png (2×1 px, 463 KB)

status quo:

grafik.png (578×1 px, 115 KB)

kostajh mentioned this in T297079: LanguageIntegrationTest.php fails when run on its own.Dec 8 2021, 1:48 PM
Daimona subscribed.Dec 8 2021, 2:49 PM
kostajh moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Dec 9 2021, 8:53 AM
kostajh mentioned this in T297082: DefaultPreferencesFactoryTest fails when run on its own.Dec 10 2021, 2:14 PM
Mainframe98 awarded a token.Dec 11 2021, 9:37 PM
gerritbot added a comment.May 30 2022, 7:29 PM

Change 801424 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] phpunit: Use TestDox output

https://gerrit.wikimedia.org/r/801424

Mainframe98 subscribed.May 31 2022, 9:21 AM
gerritbot added a comment.Jun 5 2022, 7:56 PM

Change 801424 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Use customized TestDox output

https://gerrit.wikimedia.org/r/801424

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 5 2022, 8:00 PM
gerritbot added a comment.Jun 7 2022, 8:58 AM

Change 745246 abandoned by Kosta Harlan:

[mediawiki/core@master] phpunit: Use codedungeon/phpunit-result-printer for plain phpunit

Reason:

We went with customized TestDox instead I9d8561ff868e6ff0a44d32120f2799b34d25e618

https://gerrit.wikimedia.org/r/745246

kostajh closed this task as Resolved.Jun 7 2022, 8:59 AM
kostajh claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Jun 7 2022, 9:30 AM
gerritbot added a comment.Jun 9 2022, 9:26 AM

Change 804272 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] phpunit: Reintroduce plain result printer

https://gerrit.wikimedia.org/r/804272

gerritbot added a project: Patch-For-Review.Jun 9 2022, 9:26 AM
gerritbot added a comment.Jun 10 2022, 10:00 AM

Change 804555 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] phpunit: Don't output skipped tests in summary

https://gerrit.wikimedia.org/r/804555

gerritbot added a comment.Jun 10 2022, 9:17 PM

Change 804654 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] phpunit: Restore default progress reporter and add MWTestDox option

https://gerrit.wikimedia.org/r/804654

gerritbot added a comment.Jun 12 2022, 7:23 PM

Change 804272 abandoned by Kosta Harlan:

[mediawiki/core@master] phpunit: Reintroduce plain result printer

Reason:

https://gerrit.wikimedia.org/r/804272

gerritbot added a comment.Jun 12 2022, 7:24 PM

Change 804555 abandoned by Kosta Harlan:

[mediawiki/core@master] phpunit: Don't output skipped tests in summary

Reason:

https://gerrit.wikimedia.org/r/804555

gerritbot added a comment.Jun 12 2022, 7:39 PM

Change 804654 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Restore default progress reporter and add MWTestDox option

https://gerrit.wikimedia.org/r/804654

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.16; 2022-06-13); removed MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 12 2022, 8:00 PM
gerritbot added a comment.Jun 13 2022, 1:03 PM

Change 804555 restored by Kosta Harlan:

[mediawiki/core@master] phpunit: Don't output skipped tests in summary

https://gerrit.wikimedia.org/r/804555

gerritbot added a comment.Feb 14 2024, 7:34 AM

Change 804555 abandoned by Kosta Harlan:

[mediawiki/core@master] phpunit: Don't output skipped tests in summary

Reason:

https://gerrit.wikimedia.org/r/804555

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits