Page MenuHomePhabricator
Create Task
Maniphest T302554

Some special pages (such as search) throw exceptions on beta
Closed, ResolvedPublicBUG REPORT
Actions

Description

E.g. https://cs.wikipedia.beta.wmflabs.org/wiki/Speci%C3%A1ln%C3%AD:Homepage/newcomertask/2545

[Yhhdwm3rnFbAseQZCQ066gAAAE0] /wiki/Speci%C3%A1ln%C3%AD:Homepage/newcomertask/2545 TypeError: Argument 1 passed to MediaWiki\Languages\LanguageConverterFactory::instantiateConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-master/includes/language/LanguageConverterFactory.php on line 179

Backtrace:

from /srv/mediawiki/php-master/includes/language/LanguageConverterFactory.php(151)
#0 /srv/mediawiki/php-master/includes/language/LanguageConverterFactory.php(179): MediaWiki\Languages\LanguageConverterFactory->instantiateConverter(StubUserLang)
#1 /srv/mediawiki/php-master/includes/OutputPage.php(2404): MediaWiki\Languages\LanguageConverterFactory->getLanguageConverter(StubUserLang)
#2 /srv/mediawiki/php-master/includes/OutputPage.php(2536): OutputPage->addAcceptLanguage()
#3 /srv/mediawiki/php-master/includes/OutputPage.php(2647): OutputPage->sendCacheControl()
#4 /srv/mediawiki/php-master/includes/MediaWiki.php(924): OutputPage->output(boolean)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(937): MediaWiki::{closure}()
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(564): MediaWiki->main()
#7 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Details

SubjectRepoBranchLines +/-
Remove TrivialLanguageConverter::__construct() type hintmediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

Tgr created this task.Feb 25 2022, 4:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2022, 4:41 AM
Tgr added a comment.Feb 25 2022, 5:41 AM

So the issue here is that the language (which comes from Title::getPageLanguage(), which for a special page just returns $wgLang) does not get unstubbed, and LanguageConverterFactory method signatures have been made more strict recently.

Tgr added a comment.Feb 25 2022, 5:52 AM

Can't reproduce locally because LanguageConverterFactory::getLanguageConverter() reads from cache instead (ie. something somewhere calls the method with no argument before the special page is executed).

Tgr added a comment.Feb 25 2022, 6:45 AM

A less niche special page that's affected is search.

Tgr added a comment.Feb 25 2022, 6:45 AM

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/765672 ; I forgot to add the task number.

Tgr claimed this task.Feb 25 2022, 6:46 AM
Tgr moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr moved this task from QA to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Not actually fixed, just shifted the issue a bit.

[Yhh7PjFNYH4X7sFKL3raOwAAAAY] /wiki/Speci%C3%A1ln%C3%AD:Homepage/newcomertask/2545 TypeError: Argument 1 passed to TrivialLanguageConverter::__construct() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-master/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php on line 244

Backtrace:

from /srv/mediawiki/php-master/includes/language/TrivialLanguageConverter.php(58)
#0 /srv/mediawiki/php-master/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php(244): TrivialLanguageConverter->__construct(StubUserLang, MediaWikiTitleCodec)
#1 /srv/mediawiki/php-master/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php(150): Wikimedia\ObjectFactory\ObjectFactory::getObjectFromSpec(array, array)
#2 /srv/mediawiki/php-master/includes/language/LanguageConverterFactory.php(160): Wikimedia\ObjectFactory\ObjectFactory->createObject(array, array)
#3 /srv/mediawiki/php-master/includes/language/LanguageConverterFactory.php(179): MediaWiki\Languages\LanguageConverterFactory->instantiateConverter(StubUserLang)
#4 /srv/mediawiki/php-master/includes/OutputPage.php(2404): MediaWiki\Languages\LanguageConverterFactory->getLanguageConverter(StubUserLang)
#5 /srv/mediawiki/php-master/includes/OutputPage.php(2536): OutputPage->addAcceptLanguage()
#6 /srv/mediawiki/php-master/includes/OutputPage.php(2647): OutputPage->sendCacheControl()
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(924): OutputPage->output(boolean)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(937): MediaWiki::{closure}()
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(564): MediaWiki->main()
#10 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}
gerritbot added a comment.Feb 25 2022, 6:53 AM

Change 765675 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Remove TrivialLanguageConverter::__construct() type hint

https://gerrit.wikimedia.org/r/765675

gerritbot added a project: Patch-For-Review.Feb 25 2022, 6:53 AM
gerritbot added a comment.Feb 25 2022, 7:12 AM

Change 765675 merged by jenkins-bot:

[mediawiki/core@master] Remove TrivialLanguageConverter::__construct() type hint

https://gerrit.wikimedia.org/r/765675

Tgr moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 25 2022, 7:20 AM

Now fixed for reals.

Tgr renamed this task from Special:Homepage/newcomertask throws exception on beta to Some special pages (such as search) throw exceptions on beta.Feb 25 2022, 7:21 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 25 2022, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 25 2022, 8:10 AM
Umherirrender closed this task as Resolved.Feb 25 2022, 2:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits