Page MenuHomePhabricator
Create Task
Maniphest T304325

Remove the ResourceLoaderSkinModule legacy feature stylesheet
Closed, ResolvedPublic
Actions

Description

We deprecated this in 1.37. It should be removed in 1.39. Removing it will not break anything, but skins using the feature which have not upgraded will likely see a slight degradation in skin styling on certain pages.

Outside Phabricator impacts: Citizen skin, Medik skin, mediawiki bootstrap, Chameleon

See https://www.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature for directions on how to fix this.

Impacted skins:
https://codesearch.wmcloud.org/search/?q=%22legacy%22&i=nope&files=skin.json&excludeFiles=&repos=

TODO

  • Update all skins on Gerrit
  • Raise issues for all skins not on Gerrit that are still maintained

sign off steps

  • When all skins are updated create follow up ticket for making sure declaring the legacy feature throw an exception in Mediawiki core.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Mar 21 2022, 3:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2022, 3:23 PM
gerritbot added a comment.Mar 21 2022, 3:27 PM

Change 772423 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Remove the ResourceLoaderSkinModule legacy feature

https://gerrit.wikimedia.org/r/772423

gerritbot added a project: Patch-For-Review.Mar 21 2022, 3:27 PM
Jdlrobson triaged this task as High priority.Mar 21 2022, 3:27 PM
Jdlrobson renamed this task from Remove the ResourceLoaderSkinModule legacy feature to Remove the ResourceLoaderSkinModule legacy feature stylesheet.Mar 21 2022, 3:30 PM
Ammarpad updated the task description. (Show Details)Mar 21 2022, 8:09 PM
gerritbot added a comment.Mar 24 2022, 7:30 PM

Change 772423 merged by jenkins-bot:

[mediawiki/core@master] Remove the ResourceLoaderSkinModule legacy feature stylesheet

https://gerrit.wikimedia.org/r/772423

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 24 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 24 2022, 8:11 PM
Jdlrobson closed this task as Resolved.Mar 24 2022, 8:34 PM
Jdlrobson claimed this task.

This is now done.

I've notified the impacted skins outside Github:

Jdlrobson reopened this task as Open.Mar 24 2022, 8:35 PM
Jdlrobson removed a project: MediaWiki-Core-Skin-Architecture.

Reopening and untagging for other skins.

Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.39-release board.Mar 30 2022, 3:21 PM
Jdlrobson updated the task description. (Show Details)Sep 13 2022, 12:56 AM
gerritbot added a comment.Sep 13 2022, 1:00 AM

Change 831641 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Amethyst@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831641

gerritbot added a project: Patch-For-Review.Sep 13 2022, 1:00 AM
Jdlrobson added projects: good first task, patch-welcome.Sep 13 2022, 1:00 AM
gerritbot added a comment.Sep 13 2022, 1:05 AM

Change 831641 merged by jenkins-bot:

[mediawiki/skins/Amethyst@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831641

Jdlrobson removed a project: MediaWiki-skins-Amethyst.Sep 13 2022, 1:17 AM
Jdlrobson mentioned this in rMSAM34cbbcc1fe20: Upgrade for 1.39.Sep 13 2022, 1:45 AM
gerritbot added a comment.Sep 13 2022, 3:20 PM

Change 831849 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Amethyst@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831849

gerritbot added a comment.Sep 13 2022, 3:24 PM

Change 831849 merged by jenkins-bot:

[mediawiki/skins/Amethyst@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831849

Jdlrobson mentioned this in rMSAM12a7dcaa4f2a: Upgrade for 1.39.Sep 13 2022, 3:26 PM
gerritbot added a comment.Sep 13 2022, 3:31 PM

Change 831909 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/WoOgLeShades@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831909

gerritbot added a comment.Sep 13 2022, 3:36 PM

Change 831910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Anisa@master] Upgrade to 1.39

https://gerrit.wikimedia.org/r/831910

gerritbot added a comment.Sep 13 2022, 3:49 PM

Change 831915 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/HasSomeColours@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831915

gerritbot added a comment.Sep 13 2022, 3:59 PM

Change 831921 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/GreyStuff@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831921

gerritbot added a comment.Sep 13 2022, 4:36 PM

Change 831926 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Splash@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831926

gerritbot added a comment.Sep 13 2022, 4:42 PM

Change 831850 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Splash@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831850

gerritbot added a comment.Sep 13 2022, 4:42 PM

Change 831851 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/HasSomeColours@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831851

gerritbot added a comment.Sep 13 2022, 4:42 PM

Change 831852 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Anisa@REL1_39] Upgrade to 1.39

https://gerrit.wikimedia.org/r/831852

gerritbot added a comment.Sep 13 2022, 4:45 PM

Change 831926 merged by jenkins-bot:

[mediawiki/skins/Splash@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831926

gerritbot added a comment.Sep 13 2022, 4:46 PM

Change 831909 merged by jenkins-bot:

[mediawiki/skins/WoOgLeShades@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831909

gerritbot added a comment.Sep 13 2022, 4:46 PM

Change 831915 merged by jenkins-bot:

[mediawiki/skins/HasSomeColours@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831915

gerritbot added a comment.Sep 13 2022, 4:46 PM

Change 831910 merged by jenkins-bot:

[mediawiki/skins/Anisa@master] Upgrade to 1.39

https://gerrit.wikimedia.org/r/831910

Jdlrobson removed projects: Anisa, HasSomeColours, WoOgLeShades.Sep 13 2022, 4:46 PM
Jdlrobson mentioned this in rSANI65f3f2afba48: Upgrade to 1.39.Sep 13 2022, 4:47 PM
gerritbot added a comment.Sep 13 2022, 4:47 PM

Change 831854 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/GreyStuff@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831854

gerritbot added a comment.Sep 13 2022, 4:49 PM

Change 831852 merged by jenkins-bot:

[mediawiki/skins/Anisa@REL1_39] Upgrade to 1.39

https://gerrit.wikimedia.org/r/831852

gerritbot added a comment.Sep 13 2022, 4:49 PM

Change 831851 merged by jenkins-bot:

[mediawiki/skins/HasSomeColours@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831851

gerritbot added a comment.Sep 13 2022, 4:49 PM

Change 831850 merged by jenkins-bot:

[mediawiki/skins/Splash@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831850

gerritbot added a comment.Sep 13 2022, 4:50 PM

Change 831921 merged by jenkins-bot:

[mediawiki/skins/GreyStuff@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831921

Jdlrobson mentioned this in rSANI15a6d2ed0d9f: Upgrade to 1.39.Sep 13 2022, 4:50 PM
gerritbot added a comment.Sep 13 2022, 4:52 PM

Change 831854 merged by jenkins-bot:

[mediawiki/skins/GreyStuff@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831854

gerritbot added a comment.Sep 13 2022, 4:53 PM

Change 831929 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Cavendish@master] Remove the ResourceLoaderSkinModule legacy feature

https://gerrit.wikimedia.org/r/831929

gerritbot added a comment.Sep 13 2022, 6:36 PM

Change 831950 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Truglass@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831950

gerritbot added a comment.Sep 13 2022, 6:37 PM

Change 831857 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Cavendish@REL1_39] Remove the ResourceLoaderSkinModule legacy feature

https://gerrit.wikimedia.org/r/831857

gerritbot added a comment.Sep 13 2022, 6:38 PM

Change 831858 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Truglass@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831858

gerritbot added a comment.Sep 13 2022, 6:40 PM

Change 831950 merged by jenkins-bot:

[mediawiki/skins/Truglass@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831950

gerritbot added a comment.Sep 13 2022, 6:49 PM

Change 831953 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/GuMaxDD@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831953

gerritbot added a comment.Sep 13 2022, 6:53 PM

Change 831954 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/WikimediaApiPortal@master] Remove the ResourceLoaderSkinModule legacy feature

https://gerrit.wikimedia.org/r/831954

gerritbot added a comment.Sep 13 2022, 6:55 PM

Change 831956 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/BlueSky@master] BlueSky no longer uses legacy template

https://gerrit.wikimedia.org/r/831956

gerritbot added a comment.Sep 13 2022, 6:55 PM

Change 831859 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/BlueSky@REL1_39] BlueSky no longer uses legacy template

https://gerrit.wikimedia.org/r/831859

gerritbot added a comment.Sep 13 2022, 6:58 PM

Change 831859 merged by jenkins-bot:

[mediawiki/skins/BlueSky@REL1_39] BlueSky no longer uses legacy template

https://gerrit.wikimedia.org/r/831859

gerritbot added a comment.Sep 13 2022, 6:58 PM

Change 831858 merged by jenkins-bot:

[mediawiki/skins/Truglass@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831858

gerritbot added a comment.Sep 13 2022, 7:10 PM

Change 831956 merged by jenkins-bot:

[mediawiki/skins/BlueSky@master] BlueSky no longer uses legacy template

https://gerrit.wikimedia.org/r/831956

gerritbot added a comment.Sep 13 2022, 7:10 PM

Change 831954 merged by jenkins-bot:

[mediawiki/skins/WikimediaApiPortal@master] Remove the ResourceLoaderSkinModule legacy feature

https://gerrit.wikimedia.org/r/831954

gerritbot added a comment.Sep 13 2022, 7:10 PM

Change 831953 merged by jenkins-bot:

[mediawiki/skins/GuMaxDD@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/831953

Jdlrobson mentioned this in rMSWA89923574ef7b: Remove the ResourceLoaderSkinModule legacy feature.Sep 13 2022, 7:12 PM
Jdlrobson mentioned this in rSGMD3da491cd917a: Upgrade for 1.39.
gerritbot added a comment.Sep 13 2022, 8:06 PM

Change 831929 merged by Jdlrobson:

[mediawiki/skins/Cavendish@master] Remove the ResourceLoaderSkinModule legacy feature

https://gerrit.wikimedia.org/r/831929

gerritbot added a comment.Sep 13 2022, 8:06 PM

Change 831857 merged by Jdlrobson:

[mediawiki/skins/Cavendish@REL1_39] Remove the ResourceLoaderSkinModule legacy feature

https://gerrit.wikimedia.org/r/831857

Jdlrobson removed a project: WikimediaApiPortal.Sep 13 2022, 8:15 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture; removed BlueSky, MediaWiki-skins-Cavendish, GreyStuff, MediaWiki-skins-GuMaxDD, Truglass.Sep 13 2022, 8:17 PM

Patches are now up for everything here.

Jdlrobson updated the task description. (Show Details)Sep 13 2022, 8:19 PM
Jdlrobson mentioned this in rSCAV069a9d2649b8: Remove the ResourceLoaderSkinModule legacy feature.Sep 13 2022, 8:27 PM
Jdlrobson mentioned this in rSCAVf8963d9c322a: Remove the ResourceLoaderSkinModule legacy feature.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 13 2022, 9:00 PM
Jdlrobson mentioned this in rSHASb427ae7820a0: Upgrade for 1.39.Sep 13 2022, 9:33 PM
Jdlrobson mentioned this in rSHAS8c020cce87af: Upgrade for 1.39.
gerritbot added a comment.Sep 14 2022, 5:03 PM

Change 832296 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/apex@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832296

gerritbot added a comment.Sep 14 2022, 5:03 PM

Change 832308 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/apex@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832308

gerritbot added a comment.Sep 14 2022, 5:21 PM

Change 832308 merged by jenkins-bot:

[mediawiki/skins/apex@REL1_39] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832308

gerritbot added a comment.Sep 14 2022, 5:23 PM

Change 832296 merged by jenkins-bot:

[mediawiki/skins/apex@master] Upgrade for 1.39

https://gerrit.wikimedia.org/r/832296

Jdlrobson closed this task as Resolved.Sep 14 2022, 6:13 PM

I've patched all the ones in our control and sent messages to all the ones that are not:

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits