Page MenuHomePhabricator

Refactor logging logic within Hooks::onGetUserPermissionsErrorsExpensive
Closed, ResolvedPublic

Description

While working on T304111 and trying to debug some things on the beta cluster, I think the following should be changed within Hooks::onGetUserPermissionsErrorsExpensive:

  1. Introduce logging for the odd edge case that happens here. The other early returns in this block shouldn't need logging as they should make themselves apparent in other ways or shouldn't require further debugging.
  2. The first logging block after checking if a user's IP is deny-listed should only happen when $wgSFSReportOnly is true to avoid mostly redundant logging here. This might mean moving that logging down within the if ( $wgSFSReportOnly ) conditional.

Event Timeline

sbassett moved this task from Backlog to In Progress on the user-sbassett board.
sbassett moved this task from Backlog to In Progress on the MediaWiki-extensions-StopForumSpam board.

Change 773345 had a related patch set uploaded (by SBassett; author: SBassett):

[mediawiki/extensions/StopForumSpam@master] Refactor StopForumSpam logging logic

https://gerrit.wikimedia.org/r/773345

Change 773345 merged by jenkins-bot:

[mediawiki/extensions/StopForumSpam@master] Refactor StopForumSpam logging logic

https://gerrit.wikimedia.org/r/773345

sbassett moved this task from In Progress to Done on the MediaWiki-extensions-StopForumSpam board.
sbassett moved this task from In Progress to Done on the user-sbassett board.