Remove suppression of PhanTypePossiblyInvalidDimOffset issue in core
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Mar 28 2022, 7:18 PM

Description

The PhanTypePossiblyInvalidDimOffset issue is suppressed in mediawiki/core with comment "too spammy"

This issue can hide some possible bugs and should be enabled.
It has many false positives which needs to be suppressed inline

	Subject	Repo	Branch	Lines +/-
	phan: Remove PhanTypePossiblyInvalidDimOffset suppression	mediawiki/core	master	+76 -1
	maintenance: Check return of preg_match_all in generateJsonI18n.php	mediawiki/core	master	+1 -4

Change 774564 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] phan: Remove PhanTypePossiblyInvalidDimOffset suppression

Umherirrender triaged this task as Lowest priority.

Change 774556 had a related patch set uploaded (by Krinkle; author: Umherirrender):

[mediawiki/core@master] maintenance: Check return of preg_match_all in generateJsonI18n.php

Change 774556 merged by jenkins-bot:

[mediawiki/core@master] maintenance: Check return of preg_match_all in generateJsonI18n.php

Krinkle closed this task as Resolved.Mar 29 2022, 5:01 PM

Change 774564 merged by jenkins-bot:

[mediawiki/core@master] phan: Remove PhanTypePossiblyInvalidDimOffset suppression