Image bleeding out of container
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	EAkinloose
	Jun 9 2022, 2:15 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Visit the Beta Cluster
Edit a page with VE
Add an image

What is displayed:

Screenshot 2022-06-09 at 15.08.32.png (670×624 px, 32 KB)

What should have been displayed:

Screenshot 2022-06-09 at 15.09.04.png (306×1 px, 30 KB)

**Note: It works fine on prod for now.

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Restrict img tags to the maximum available space"	mediawiki/core	master	+0 -7

Customize query in gerrit

Related Objects

Mentioned In: T113101: Images should be responsive in Vector and restrained to a max-size.
Mentioned Here: T113101: Images should be responsive in Vector and restrained to a max-size.
T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022

Event Timeline

EAkinloose created this task.Jun 9 2022, 2:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2022, 2:15 PM

This was caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/793555, which was intended to fix T113101. cc @Jdlrobson

Change 803919 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] Revert "Restrict img tags to the maximum available space"

https://gerrit.wikimedia.org/r/803919

gerritbot added a project: Patch-For-Review.Jun 9 2022, 2:34 PM

Note that the VE surface approximately uses Parsoid HTML, which this change appears not to be compatible with. The selector seems scarily generic (.mw-parser-output img) so it should be tested against a wide range of content (e.g. galleries and other rich media extensions in both parsers) before merging it again.

• Esanders added a project: Regression.Jun 9 2022, 2:44 PM

• Esanders updated the task description. (Show Details)

ppelberg subscribed.Jun 9 2022, 3:25 PM

Jdlrobson mentioned this in T113101: Images should be responsive in Vector and restrained to a max-size..Jun 9 2022, 3:51 PM

Change 803919 merged by jenkins-bot:

[mediawiki/core@master] Revert "Restrict img tags to the maximum available space"

https://gerrit.wikimedia.org/r/803919

Jdlrobson lowered the priority of this task from Unbreak Now! to Needs Triage.Jun 9 2022, 4:17 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2022, 4:30 PM

Thanks

Moving back to T113101

All good now.

Screenshot 2022-06-09 at 18.04.13.png (804×994 px, 73 KB)

	F35222946: Screenshot 2022-06-09 at 18.04.13.png
	Jun 9 2022, 5:15 PM

	F35222236: Screenshot 2022-06-09 at 15.09.04.png
	Jun 9 2022, 2:15 PM

	F35222233: Screenshot 2022-06-09 at 15.08.32.png
	Jun 9 2022, 2:15 PM

Image bleeding out of containerClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Image bleeding out of container
Closed, ResolvedPublicBUG REPORT
Actions