Page MenuHomePhabricator

move ext.pageTriage.views.toolbar into extension.json
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):

The move ext.pageTriage.views.toolbar module is currently defined via hook as it checks whether Wikilove is enabled so it's a little hidden a way - adding a small amount of friction to newcomers to the codebase who expect all modules to be defined in extension.json. However, the WIkilove extension only modifies the value of PageTriageCurationModules - which can be done via a callback function. I suggest we introduce a new configuration variable PageTriageCurationDependencies to ensure that the page load stays as is, and remove the overhead of changing the module based on what's installed.

Benefits (why should this be implemented?):

  • Easier to understand the code when all defined in extension.json
  • Easier to refactor module code
  • Makes the plugin system more intuitive - so we could potentially extend this with other functionality later.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 904834 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageTriage@master] move ext.pageTriage.views.toolbar into extension.json (1/3)

https://gerrit.wikimedia.org/r/904834

Change 904835 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageTriage@master] move ext.pageTriage.views.toolbar into extension.json (2/3)

https://gerrit.wikimedia.org/r/904835

Change 904836 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageTriage@master] move ext.pageTriage.views.toolbar into extension.json (3/3)

https://gerrit.wikimedia.org/r/904836

Change 904834 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] move ext.pageTriage.views.toolbar into extension.json (1/3)

https://gerrit.wikimedia.org/r/904834

Change 904835 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] move ext.pageTriage.views.toolbar into extension.json (2/3)

https://gerrit.wikimedia.org/r/904835

Change 904836 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] move ext.pageTriage.views.toolbar into extension.json (3/3)

https://gerrit.wikimedia.org/r/904836

@Jdlrobson. This one's all done, right? OK to close? Thanks for your work on this.

Yes! Thanks for checking :)