Error: Call to a member function serialize() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	hashar
	May 11 2023, 1:55 PM

Description

Error

service.version: 1.41.0-wmf.8
trace.id: 534fafab-ed4d-4758-9787-b470b7ff97d3
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Error: Call to a member function serialize() on null

error.stack_trace

from /srv/mediawiki/php-1.41.0-wmf.8/includes/parser/Parsoid/Config/PageContent.php(80)
#0 /srv/mediawiki/php-1.41.0-wmf.8/vendor/wikimedia/parsoid/src/Wt2Html/PageConfigFrame.php(27): MediaWiki\Parser\Parsoid\Config\PageContent->getContent(string)
#1 /srv/mediawiki/php-1.41.0-wmf.8/vendor/wikimedia/parsoid/src/Config/Env.php(285): Wikimedia\Parsoid\Wt2Html\PageConfigFrame->__construct(Wikimedia\Parsoid\Config\Env, MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\Parsoid\Config\SiteConfig)
#2 /srv/mediawiki/php-1.41.0-wmf.8/vendor/wikimedia/parsoid/src/Parsoid.php(162): Wikimedia\Parsoid\Config\Env->__construct(MediaWiki\Parser\Parsoid\Config\SiteConfig, MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\Parsoid\Config\DataAccess, ParserOutput, array)
#3 /srv/mediawiki/php-1.41.0-wmf.8/vendor/wikimedia/parsoid/src/Parsoid.php(216): Wikimedia\Parsoid\Parsoid->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, ParserOutput, array)
#4 /srv/mediawiki/php-1.41.0-wmf.8/includes/parser/Parsoid/ParsoidOutputAccess.php(298): Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array, NULL, ParserOutput)
#5 /srv/mediawiki/php-1.41.0-wmf.8/includes/parser/Parsoid/ParsoidOutputAccess.php(465): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->parseInternal(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#6 /srv/mediawiki/php-1.41.0-wmf.8/includes/parser/Parsoid/ParsoidOutputAccess.php(244): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->parse(MediaWiki\Page\PageStoreRecord, ParserOptions, array, MediaWiki\Revision\RevisionStoreRecord)
#7 /srv/mediawiki/php-1.41.0-wmf.8/includes/jobqueue/jobs/ParsoidCachePrewarmJob.php(127): MediaWiki\Parser\Parsoid\ParsoidOutputAccess->getParserOutput(MediaWiki\Page\PageStoreRecord, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, integer)
#8 /srv/mediawiki/php-1.41.0-wmf.8/includes/jobqueue/jobs/ParsoidCachePrewarmJob.php(140): ParsoidCachePrewarmJob->doParsoidCacheUpdate()
#9 /srv/mediawiki/php-1.41.0-wmf.8/extensions/EventBus/includes/JobExecutor.php(79): ParsoidCachePrewarmJob->run()
#10 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#11 {main}

Impact

No idea

Notes

There are few since 1.41.0-wmf.8 got deployed to all wikis on Thursday.

Details

Request URL: https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php

	Subject	Repo	Branch	Lines +/-
	Catch RevisionAccessException in ParsoidOutputAccess	mediawiki/core	master	+87 -57
	Check early for a badrevision exception when Parsoid tries to getContent	mediawiki/core	master	+28 -6

Customize query in gerrit

Related Objects

Mentioned In: T338925: MediaWiki\Revision\BadRevisionException: The content of this revision is missing or corrupted (bad schema)

Event Timeline

hashar created this task.May 11 2023, 1:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2023, 1:55 PM

hashar moved this task from Untriaged to May 2023 on the Wikimedia-production-error board.May 11 2023, 2:04 PM

Jgiannelos removed a project: Content-Transform-Team.May 11 2023, 2:08 PM

Jgiannelos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.May 11 2023, 2:15 PM

Some example urls: /w/rest.php/os.wikipedia.org/v3/page/pagebundle/1871/107265, w/rest.php/os.wikipedia.org/v3/page/pagebundle/1874/107271, /w/rest.php/jv.wikipedia.org/v3/page/pagebundle/Kuthowinangun%2C_Kebum%C3%A8n/214173 ...

Clicking around on these revisions, I see error messages that say: "The text of this revision is missing or corrupted.". So, looks like this is a case of missing exception handling.

Arlolra claimed this task.Jun 2 2023, 5:36 PM

Arlolra triaged this task as Medium priority.

Arlolra added a project: Content-Transform-Team-WIP.

Change 926624 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Try to getContent to check for a badrevision exception

https://gerrit.wikimedia.org/r/926624

gerritbot added a project: Patch-For-Review.Jun 2 2023, 8:34 PM

Arlolra moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.Jun 2 2023, 8:57 PM

Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Jun 5 2023, 9:46 PM

Change 926624 merged by jenkins-bot:

[mediawiki/core@master] Check early for a badrevision exception when Parsoid tries to getContent

https://gerrit.wikimedia.org/r/926624

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2023, 10:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 5 2023, 11:00 PM

Arlolra moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Jun 9 2023, 2:46 PM

Post deploy,

arlolra@scandium:~$ NO_PROXY="" no_proxy="" curl --proxy scandium.eqiad.wmnet:80 http://os.wikipedia.org/w/rest.php/os.wikipedia.org/v3/page/pagebundle/1871/107265
{"message":"The text of this revision is missing or corrupted.","httpCode":410,"httpReason":"Gone"}

Arlolra mentioned this in T338925: MediaWiki\Revision\BadRevisionException: The content of this revision is missing or corrupted (bad schema).Jun 13 2023, 5:56 PM

Change 929777 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Catch pageConfig errors in ParsoidOutputAccess

https://gerrit.wikimedia.org/r/929777

gerritbot added a project: Patch-For-Review.Jun 13 2023, 6:37 PM

Change 929777 merged by jenkins-bot:

[mediawiki/core@master] Catch RevisionAccessException in ParsoidOutputAccess

https://gerrit.wikimedia.org/r/929777

Maintenance_bot removed a project: Patch-For-Review.Jun 27 2023, 11:30 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.16; 2023-07-04); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 28 2023, 1:00 AM