Page MenuHomePhabricator

Function Evaluator widget: Setting the input values marks the page as Dirty
Closed, ResolvedPublicBUG REPORT

Description

Description

Setting the input values in the Function Evaluator widget triggers the action setDirty so the page is flagged as having changes, when there are none.

Steps to reproduce:

  1. Go to https://wikifunctions.beta.wmflabs.org/wiki/Z10038?action=edit&uselang=en
  2. Change the input values in the function evaluator widget

Observed behavior:

  • Publish button is activated, even though there are no changes to be saved
  • Exiting the page triggers the "confirm exit" dialog

Expected behavior (Acceptance criteria):

  • Changes in the ZObjectKeyValue component inside the function evaluator don't trigger setDirty

Completion checklist

Event Timeline

Change 948997 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Set isDirty only when making changes in main object, not on detached objects

https://gerrit.wikimedia.org/r/948997

Jdforrester-WMF changed the task status from Open to In Progress.Aug 16 2023, 5:59 AM
Jdforrester-WMF assigned this task to gengh.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.

Change 948997 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Set isDirty only when making changes in main object, not on detached objects

https://gerrit.wikimedia.org/r/948997

Etonkovidova updated the task description. (Show Details)