Page MenuHomePhabricator

Empty "Join event chat group" section in event page after an event has ended
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create an event that has a chat link
  • Wait for the event to end (or set its end date to the past after you've created it)
  • Visit the event page as someone who is NOT an organizer or participant of the event (logged-out works, too)
  • Click "More details" to open the info dialog

What happens?:
There's an empty "Join event chat group" section with no content in it.

What should have happened instead?:
The "Join event chat group" section should be hidden.

Other information (browser name/version, screenshots, etc.):

  • Reproducible on meta: https://meta.wikimedia.org/wiki/Event:International_Youth_Day_2023
  • For context, when the event is still open we display the following message when a non-participant opens the dialog: «Register to view the chat group link.». But if the event has ended, you can no longer register. I don't think it would be useful to have a separate error message for this scenario (to explain that the event has a chat link, but there's no way for people to see it).
  • The same thing happens not just when an event has ended, but also when the registration is closed, or if the user is blocked.
  • The same bug also affects the meeting link section, under the same conditions, and that also has a message asking users to register. I'm not sure if we need a separate task for that.

image.png (1×718 px, 83 KB)

Event Timeline

Decision: we will hide the "Join event chat group" section. The "Online event" section can stay because it's still marginally useful.

Daimona set the point value for this task to 2.

Change #1035755 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Hide chat section when event has ended

https://gerrit.wikimedia.org/r/1035755

Change #1035755 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Hide chat section when event has ended

https://gerrit.wikimedia.org/r/1035755

vaughnwalters added subscribers: ifried, vaughnwalters.

✅ The "Join event chat group" section should be hidden.

"Join event chat group" link is now hidden after an event has ended, Testing on this event.

Screenshot 2024-05-24 at 11.13.17 AM.png (846×784 px, 66 KB)


Moving this to product sign off because the AC is met for this ticket but @ifried I am wondering if we should also make a ticket to do the same thing on the Event Details page? Check the same event as listed above and you can see where it says "You need to register to see this information" but the user can't register for the event because it is closed.

This has been fixed (see attached screenshot), so I marking this as Done.

Screenshot 2024-06-07 at 3.29.21 PM.png (1×1 px, 193 KB)