Page MenuHomePhabricator

[Generalised errors] Invalid path parameter
Closed, ResolvedPublic5 Estimated Story Points

Description

Acceptance criteria:

  • Current messages it will replace: Invalid ID forms (item, property, statement and site), invalid language code (labels, descriptions, aliases) across all endpoints
  • HTTP status code: 400
  • Error code: invalid-path-parameter
  • Error message: Invalid path parameter: '{parameter}'
  • Context: "parameter": "{matching element in path parameter in the OpenAPI spec}"

Event Timeline

Ifrahkhanyaree_WMDE renamed this task from [Generalised errors] Incorrect path parameter to [Generalised errors] Invalid path parameter.Jun 5 2024, 11:02 AM
Ifrahkhanyaree_WMDE updated the task description. (Show Details)
Ifrahkhanyaree_WMDE set the point value for this task to 5.
Jakob_WMDE subscribed.

Task breakdown notes:

  • adjust the request validating deserializers accordingly
  • adjust the examples in the spec

Change #1047169 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Replace the `invalid-item-id` error with the generalized `invalid-path-parameter` one.

https://gerrit.wikimedia.org/r/1047169

Change #1047170 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Use `invalid-path-parameter` for the remaining parameters.

https://gerrit.wikimedia.org/r/1047170

Change #1047531 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Replace the `invalid-property-id` error with the generalized `invalid-path-parameter` one.

https://gerrit.wikimedia.org/r/1047531

Change #1047541 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Replace the `invalid-statement-id` error with the generalized `invalid-path-parameter` one.

https://gerrit.wikimedia.org/r/1047541

Change #1047170 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Use `invalid-path-parameter` for the remaining parameters.

Reason:

- will be divided into smaller patches

https://gerrit.wikimedia.org/r/1047170

Change #1047558 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Use `invalid-path-parameter` for invalid language codes and site ids.

https://gerrit.wikimedia.org/r/1047558

Change #1047169 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace the `invalid-item-id` error with the generalized `invalid-path-parameter` one.

https://gerrit.wikimedia.org/r/1047169

Change #1047531 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace `invalid-property-id` with `invalid-path-parameter`

https://gerrit.wikimedia.org/r/1047531

Change #1047541 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace `invalid-statement-id` with `invalid-path-parameter`

https://gerrit.wikimedia.org/r/1047541

Change #1047558 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use `invalid-path-parameter` for invalid language codes and site ids.

https://gerrit.wikimedia.org/r/1047558