Leipzig-based software developer. Previously, I worked on Wikidata, and before that on DokuWiki and WikiMatrix.
Tech: My Contributions
GitHub: micgro42
LinkedIn: https://www.linkedin.com/in/celenduin
🦔
Leipzig-based software developer. Previously, I worked on Wikidata, and before that on DokuWiki and WikiMatrix.
Tech: My Contributions
GitHub: micgro42
LinkedIn: https://www.linkedin.com/in/celenduin
🦔
Follow-up from Slack:
Not exactly UBN, but still we should ideally get a fix + backport done today.
Mh, unrelated changes aside, when I try to blank that field locally, I get a validation error for it: "NULL value found, but a string is required".
The first alternative that comes to mind right away is to follow the format that the API uses to work around this issue:
Specifically, Amir proposes to change the first paragraph of the current text (added like that in T367619):
Moving this to doing for creating some Grafana panels for the metrics added.
In T368405#9945822, @Sfaci wrote:I have been exploring a bit more the changes around 18th of May and there is no change that we can correlate to these events. The service code haven't been changed this year and the only changes we have done are related to the kubernetes configuration as I mentioned before. The closest change, regarding time, is https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1033405 where some network policies were changed on 24th May (I guess it was deployed after that date) but I can't say whether that change could be related to this. @BTullis any idea here?
Taking a look at the grafana dashboard for edit-analytics for the last two months it seems that the latency is pretty stable (there are a couple of peaks but the rest of the chart is fine) so, considering that, I don't know what happens but I would say that these events are not related to the service itself. Regarding the timeouts you mentioned, just wondering if there is something preventing your app from reaching the service.
I think this can be closed.
In T363855#9953086, @Michael wrote:The remaining work has been split out into the subtasks:
- T369257: Server validation errors for items of Arrays with custom controls need special handling
- T369259: Server validation errors should show better label in main validation message link
This task can move forward to QA again once those tasks have been resolved.
No QA for this technical sub-task specifically, only for the parent: T363855: Improve validation errors wording and behavior
No QA for this technical sub-task specifically, only for the parent: T363855: Improve validation errors wording and behavior
Ah, after destroying all the containers and volumes, and carefully recreating them from scratch, it now seems to actually work!
In T369811#9980859, @Addshore wrote:And does search work etc when configured? :)
In T369591#9971327, @Sjoerddebruin wrote:Also, when opening on of the popups that feature a new item it briefly flashes very light blue in dark mode.
With the new binary the command succeeded, downloaded all the images and now I see "elasticsearch":true on Special:Mwdd. Thanks!
I've created a proof of concept: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1053632
Curious to hear your thoughts.
I don't seem to be able to reproduce any of the issues mentioned in the descriptions on enwiki's Special:Notifications (already on .wmf13). @Etonkovidova can you confirm?
This was a relatively rare error to begin with, so we probably need some time to verify that it is indeed gone. But if we see no new occurrences of it between July 19th 2024 and August 9th 2024 (4 weeks), then, I think, we can consider this verified as fixed.
Another sensible measure could be to add benchmarking in CI for this. That exists already in GrowthExperiments (currently broken: T329280), but CommunityConfiguration should not have those problems (that is, it does not depend on any other extensions), and ensuring that validation stays fast is even more important for CommunityConfiguration.
- Setting a default value for the maximum is tricky. CC does not allow default empty values (null) for some types, like the case of the number and integer. We could display a "very big" number as the default, but we cannot set an "empty" value for the field to signal the special case "don't apply the validation constraint if value is not set".
I'm not sure if I'm the best person to weigh in, as I'm neither a native speaker, nor have any training in writing copy. I find "Currently no structured tasks available" to be clear to understand. "Currently, no structured tasks are available" on the other hand feels ever so slightly more garden-path-y with the positive verb "are" emphasizing that something is available. "Currently, there are no structured tasks available." feels a bit better in that regard. But I'm probably overthinking this. (Also again: I don't really know what I'm talking about. I'm just a developer^^.)
Thank you so much! I'm sorry for responding late, distracted with other matters.
I have a commit message template in my personal dotfiles that is currently the following:
Moving to Up Next to be considered for the next sprint, and adding Technical-Debt as requested for maintenance work by @DMburugu.
Beta wiktionary is working again: https://fr.wiktionary.beta.wmflabs.org/wiki/Accueil
In T369277#9953745, @Urbanecm_WMF wrote:Great catch, thanks for reporting. What about checking GEHomepageSuggestedEditsEnabled in CommunityConfigurationLoader, and returning an empty array if that is the case? That should work, and while it might not be exactly equivalent, it should be at least close?
Looking through GrowthExperiments' extension.json, I notice that the GrowthExperimentsNewcomerTasksConfigurationLoader service is loaded in a lot of places.
The remaining work has been split out into the subtasks:
Medium per parent priority.
Medium per parent priority.
In T367792#9950135, @bmartinezcalvo wrote:@Michael we've updated the Field's Guidelines including a recommendation about how to use the label's description and the helper text. We've included this info within the Field's guidelines since both description and helper text are elements of Field component. Let us know your feedback.