Page MenuHomePhabricator

epriestley (Evan Priestley)
Phacility

Projects

Heute

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 24 2014, 11:28 PM (510 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Evanpriestley [ Global Accounts ]

I work on Phabricator.

Neueste Aktivität

May 30 2021

epriestley added a comment to T283980: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending..

The upstream phabricator[2] might also go away though I don't think that is quite as imminent.

May 30 2021, 7:34 PM · Release-Engineering-Team (Seen), User-Matthewrbowker, Phabricator

Mar 24 2021

epriestley added a comment to T274228: Phabricator should cache tasks for a few minutes for logged-out users.

It's perfectly fine to configure cluster.databases with one service, and Phabricator internally (in effect) builds a one-service cluster.databases configuration (by looking at mysql.user, mysql.host, etc) if your configuration is empty. Swapping from mysql.user to cluster.databases causes (or, at least, should cause) no change in behavior -- and is happening behind the scenes anyway -- it just gives you access to the persistent flag.

Mar 24 2021, 4:30 PM · SRE, Traffic, Phabricator

Mar 11 2021

epriestley added a comment to T277132: Herald rule to suppress Task activity? (and just receive Task creation).

When:
[ Projects ][ include any of ][ X, Y, Z, ... ]
Take these actions [ only the first time this rule matches ]:
[ Send me an email ]

Mar 11 2021, 3:55 PM · Upstream, Phabricator (Upstream)

Feb 9 2021

epriestley added a comment to T274228: Phabricator should cache tasks for a few minutes for logged-out users.

I suspect you're seeing that because when you reload a page by issuing a "Reload" command in your browser, most (all?) modern browsers interpret that to mean "Reload the page, skipping some/most/all caches". That is, the cache behavior of these sequences differs:

Feb 9 2021, 7:12 PM · SRE, Traffic, Phabricator
epriestley added a comment to T274228: Phabricator should cache tasks for a few minutes for logged-out users.

Eventually Phabricator ran out of local sockets (30k limit):

Feb 9 2021, 6:47 PM · SRE, Traffic, Phabricator
epriestley added a comment to T274228: Phabricator should cache tasks for a few minutes for logged-out users.

We need an easy way to tell logged-out traffic apart in our caching layer.

Feb 9 2021, 5:04 PM · SRE, Traffic, Phabricator

Dec 7 2020

epriestley added a comment to T181031: Allow others than admins to edit forms.

I'm happy to take a look at this if someone with access has a chance to figure out where it isn't working on your end -- my expectation is that it's supposed to work, but I could definitely have overlooked something.

Dec 7 2020, 5:07 PM · Phabricator

Aug 13 2020

epriestley closed T13380: "Go" search should check if page exists in namespaces other than main as Resolved by committing rARCf3f31155b761: Format "arc land" passthru commands more nicely, and execute them from CWD.
Aug 13 2020, 9:38 PM · MediaWiki-Search
epriestley changed the status of T9753: Math: \def as shortcut for \stackrel{def}{=} from Declined to Resolved by committing rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3.
Aug 13 2020, 9:37 PM · Math
epriestley changed the status of T13498: Whitespace should be fixed automatically from Declined to Resolved by committing rARC18799c182921: Switch file uploader in "arc diff" to use ConduitEngine.
Aug 13 2020, 9:37 PM · MediaWiki-Page-editing
epriestley changed the status of T13489: Merge Help namespace into Project in the Hungarian Wikipedia from Declined to Resolved by committing rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree.
Aug 13 2020, 9:36 PM · Shell, Wikimedia-Site-requests

Jul 10 2020

epriestley added a comment to T257633: Feature request: New notification option for when somebody @mentions you in a Task.

In some cases, you can currently do something similar with "Mail Stamps". Mail which mentions you is stamped with mention(@username). The stamp appears in the X-Phabricator-Stamps header, or in the mail body if you set SettingsEmail FormatSend Stamps to include it (this is mostly for Gmail, which does not -- or, at least, did not at the time -- have client rules to support filtering based on headers).

Jul 10 2020, 3:39 PM · Upstream, Phabricator (Upstream)

May 4 2020

epriestley moved T245089: Restore highlighting of target comment in Phabricator from Backlog to Patch merged upstream on the Upstream board.

It [the yellow highlight] was nice to bring the user's attention to the specific comment they were being linked to.

May 4 2020, 5:03 PM · Phabricator (2020-09-10), Upstream
epriestley moved T245089: Restore highlighting of target comment in Phabricator from Backlog to Solved upstream on the Phabricator (Upstream) board.
May 4 2020, 5:03 PM · Phabricator (2020-09-10), Upstream

May 3 2020

epriestley moved T219503: Overlap between (Status, Priority, Story Points and Visible To) in phabricator mobile version from Backlog to Patch merged upstream on the Upstream board.

See https://secure.phabricator.com/T13476 in the upstream.

May 3 2020, 5:24 PM · Phabricator (2020-02-13), Upstream, Mobile
epriestley moved T219503: Overlap between (Status, Priority, Story Points and Visible To) in phabricator mobile version from Backlog to Solved upstream on the Phabricator (Upstream) board.
May 3 2020, 5:23 PM · Phabricator (2020-02-13), Upstream, Mobile
epriestley removed a project from T70360: Match a newline in the code is not possible: Phabricator (Upstream).

(This doesn't seem to be related to Phabricator.)

May 3 2020, 5:20 PM · Upstream, CodeEditor
epriestley moved T243483: Unknown search function "XXX". Supported functions are: all, title, body, core, comment. from Reported Upstream to Patch merged upstream on the Upstream board.

I added a hint about this to the upstream in https://secure.phabricator.com/D21209.

May 3 2020, 5:17 PM · Phabricator (Upstream), Upstream
epriestley moved T243483: Unknown search function "XXX". Supported functions are: all, title, body, core, comment. from Backlog to Solved upstream on the Phabricator (Upstream) board.
May 3 2020, 5:16 PM · Phabricator (Upstream), Upstream

May 1 2020

epriestley moved T243483: Unknown search function "XXX". Supported functions are: all, title, body, core, comment. from Backlog to Reported Upstream on the Upstream board.

This error got a little stricter recently so it might crop up more often after the next upgrade, and it's normally hard to hit by accident so I don't mind being more verbose in handling it. I can add a hint to the error message, something like:

May 1 2020, 11:00 PM · Phabricator (Upstream), Upstream

Apr 28 2020

epriestley changed the status of T13481: "Hard-coded" redirects for reserved characters and Weather-in-Londons from Declined to Resolved by committing rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a….
Apr 28 2020, 7:34 PM · MediaWiki-General

Feb 18 2020

epriestley added a comment to T245472: [Regression] Use of monospaced font URL descriptions no longer display correctly.

Sounds good. It would be nice to make the parser more flexible here and allow, say, [[ X | aaa **bbb** ccc //ddd// eee ]] to render a link with bold and italics, or possibly let [[ X | {icon ... color=green} qqq ]] and similar work to render a link with an icon, but these feel like pretty small nice-to-have improvements and they'd be fairly complex to implement.

Feb 18 2020, 3:06 PM · Upstream, Phabricator (Upstream), Regression
epriestley added a comment to T245472: [Regression] Use of monospaced font URL descriptions no longer display correctly.

This was changed to fix a security vulnerability, see https://secure.phabricator.com/D20937.

Feb 18 2020, 12:03 AM · Upstream, Phabricator (Upstream), Regression

Feb 11 2020

epriestley changed the status of T13480: Immediately after deleting a talk page, the discussion / talk link at the top of the page will still show as blue, rather than as red. from Declined to Resolved by committing rPHABc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and….
Feb 11 2020, 9:30 PM · MediaWiki-Special-pages
epriestley changed the status of T13482: Interwiki and interlanguage links must use lowercase codes from Declined to Resolved by committing rPHAB7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists.
Feb 11 2020, 9:30 PM · MediaWiki-General
epriestley changed the status of T13476: Rename namespaces on Hungarian Wikipedia from Invalid to Resolved by committing rPHABd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other….
Feb 11 2020, 9:29 PM · Wikimedia-Language-setup

Jan 15 2020

epriestley added a comment to T224082: No results for specific string in Global Phab Search, while Advanced Search lists expected results (due to ElasticSearch for Global Search vs Ferret for Maniphest Search)?.

Ah, yeah -- I suspect the patch with the forked highlighting/display behavior should carry over to Ferret without significant changes. This is also still behavior I plan to bring upstream in some form, I just wasn't satisfied with my initial stab at it back in the day.

Jan 15 2020, 1:17 AM · Phabricator (2020-01-23)

Dec 16 2019

epriestley closed T12668: Detect and notify user of extremely low (probably accidental) POST limits as Resolved by committing rARCa76054f8d66d: Update "arc help land" to reference Perforce support.
Dec 16 2019, 4:01 PM · TestMe, MediaWiki-Installer

Nov 22 2019

epriestley added a comment to T181031: Allow others than admins to edit forms.

If you do this:

Nov 22 2019, 8:08 PM · Phabricator

Oct 16 2019

epriestley added a comment to T235339: Phabricator fonts look broken on systems with JoyPixels (formerly EmojiOne) installed.

(See https://discourse.phabricator-community.org/t/website-specifies-emoji-font-in-body-tag/2139/ for the upstream position on this -- basically, that this is bug with EmojiOne/JoyPixels and they should not replace font X with "replacement" font Y when font Y defines a substantially different set of glyphs from font X and changes behavior when it replaces it.)

Oct 16 2019, 3:40 PM · Upstream, Phabricator (Upstream)

Sep 27 2019

epriestley added a comment to T233998: ArgumentCountError on Phabricator.

(That change is from 5 seconds ago so this would just be something to keep an eye on for the next deployment.)

Sep 27 2019, 5:58 PM · Phabricator
epriestley added a comment to T233998: ArgumentCountError on Phabricator.

Ignore me if I have no clue what's going on, but I added another call to this method in https://secure.phabricator.com/D20842, which may need adjustment if you've tweaked it (which I think is what's going on here, per rPHABae334e4589a0413c1eb8a9e8d993e553bfeff478).

Sep 27 2019, 5:57 PM · Phabricator

Sep 13 2019

matmarex awarded T232600: Some Phabricator boards do not load cards anymore in Chrome 77 a The World Burns token.
Sep 13 2019, 10:57 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

Nice! Thanks for everyone's help hunting this one down, this was definitely one of the most bizarre bugs I've ever run into.

Sep 13 2019, 8:35 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
RHo awarded T232600: Some Phabricator boards do not load cards anymore in Chrome 77 a Yellow Medal token.
Sep 13 2019, 8:30 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley moved T232600: Some Phabricator boards do not load cards anymore in Chrome 77 from Upstreamed to Solved upstream on the Phabricator (Upstream) board.

Since the downsides are fairly minor, I've landed the workaround above into the Phabricator upstream in https://secure.phabricator.com/D20812.

Sep 13 2019, 2:03 AM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome

Sep 12 2019

epriestley added a comment to T232702: Phabricator Maniphest showing "Cancelar suscripción" in English user interface.

There's technically a transaction history on Settings, but it's not useful today since the stories don't render properly (only @MZMcBride will be able to see anything here):

Sep 12 2019, 11:39 PM · Phabricator
epriestley moved T231734: Add custom policy to access denied message from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.

This is referenced upstream by https://secure.phabricator.com/T13411 and "resolved" upstream by https://secure.phabricator.com/D20806.

Sep 12 2019, 4:18 PM · Upstream, Phabricator (Upstream)
epriestley moved T211498: "Custom Policy" value in "Policy Details" could provide more information what exactly it means from Backlog to Solved upstream on the Phabricator (Upstream) board.

This is referenced upstream by https://secure.phabricator.com/T13411 (and, earlier, by https://secure.phabricator.com/T6802).

Sep 12 2019, 4:08 PM · Phabricator (2019-12-19), Upstream
epriestley moved T130881: Herald changes shown in user feed from Upstreamed to Solved upstream on the Phabricator (Upstream) board.

I believe this is resolved by https://secure.phabricator.com/D20797.

Sep 12 2019, 1:35 AM · Phabricator (2019-12-19), Upstream

Sep 11 2019

epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

I upstreamed this here:

Sep 11 2019, 6:08 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

Here is a simplified document which freezes Chrome 77:

Sep 11 2019, 5:51 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

Broken in Chrome:

Sep 11 2019, 5:03 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

There's nothing special about that task

Sep 11 2019, 4:58 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

Here's a view of the board with exactly one task that freezes in Chrome for me:

Sep 11 2019, 4:46 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

Here's what I'm observing:

Sep 11 2019, 4:38 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

I think that's just "the freeze is after WorkboardDropEffect.js" is loaded. All the class definitions load first without actually executing anything or causing side effects (like JX.WorkboardDropEffect). We seem to make it through this part okay, and I think that's what you're seeing.

Sep 11 2019, 4:24 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

Yeah, this is wildly difficult to debug with Chrome's tools. The profiler freezes and I can't get it to unfreeze, stopping execution freezes without breaking anywhere, and when the window freezes the entire window locks up so you have to close it. This discards all your debugger state, and you have to open a new window, reset all your debugger state, then load the page. This isn't even very helpful since breaking on DOMContentLoaded doesn't get anywhere.

Sep 11 2019, 4:10 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

Aha! I can reproduce on "Growth-Team", just not the original "Language-Team" project.

Sep 11 2019, 3:50 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
epriestley added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

This loads okay for me in Chrome 77 on macOS 10.14:

Sep 11 2019, 3:28 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome

Sep 9 2019

epriestley moved T231623: Allow Herald to remove flags (under "Maniphest Tasks > Personal") from Backlog to Solved upstream on the Phabricator (Upstream) board.

Filed upstream as https://secure.phabricator.com/T13409.

Sep 9 2019, 8:02 PM · Phabricator (2019-12-19), Upstream

Sep 3 2019

epriestley added a comment to T231734: Add custom policy to access denied message.

You kinda answered your question. I can ask "someone", but who is that someone?

Sep 3 2019, 10:40 PM · Upstream, Phabricator (Upstream)
epriestley added a comment to T231734: Add custom policy to access denied message.

See also T211498.

Sep 3 2019, 9:16 PM · Upstream, Phabricator (Upstream)

Sep 1 2019

epriestley added a comment to T227300: Document workboard column triggers.

if you use the 'move on workboard' option it does nothing. That is what I missed. Is that the intended behaviour?

Sep 1 2019, 12:03 AM · Documentation, Phabricator

Aug 30 2019

epriestley added a comment to T231667: Phabricator: Simplify the multifactor auth reset procedure.

See also some discussion in T187256.

Aug 30 2019, 7:16 PM · Phabricator

Aug 15 2019

epriestley moved T230217: "AphrontQueryException: #1052: Column 'id' in where clause is ambiguous" when going to the second result page of Project search from Backlog to Solved upstream on the Phabricator (Upstream) board.

I filed this upstream as https://secure.phabricator.com/T13378.

Aug 15 2019, 7:12 PM · Phabricator (2019-08-22), Upstream
epriestley edited projects for T230217: "AphrontQueryException: #1052: Column 'id' in where clause is ambiguous" when going to the second result page of Project search, added: Phabricator (Upstream); removed Phabricator.
Aug 15 2019, 7:11 PM · Phabricator (2019-08-22), Upstream

Aug 8 2019

epriestley moved T229757: Autofocus on TOTP input field from Backlog to Solved upstream on the Phabricator (Upstream) board.
Aug 8 2019, 7:55 PM · Phabricator (2019-08-22), Upstream
epriestley moved T230001: Error viewing project feed when many recent changes were in access restricted tasks: "Query (of class "PhabricatorFeedQuery") overheated: examined more than 500 raw rows without finding 50 visible objects" from Backlog to Solved upstream on the Phabricator (Upstream) board.

This should be resolved upstream by https://secure.phabricator.com/D20704.

Aug 8 2019, 7:54 PM · Phabricator (2019-08-22), Upstream
epriestley added a comment to T229757: Autofocus on TOTP input field.

This should be resolved upstream by https://secure.phabricator.com/D20703.

Aug 8 2019, 5:28 PM · Phabricator (2019-08-22), Upstream

Aug 2 2019

epriestley moved T85440: Footer is not visible in workboards from Ready To Go to Feedback From Upstream on the Phabricator (Upstream) board.

This is moderately technically complicated, the use case isn't clear to me (why is it important to access the footer on these particular pages?), and making this change on full-screen interfaces would cannibalize screen space. I suspect that users are very rarely interested in accessing the footer from workboards and would generally prefer the extra space for showing cards.

Aug 2 2019, 7:29 PM · Upstream, Phabricator (Upstream)
epriestley moved T197935: Multiple grep results in one line displayed incorrectly from Upstreamed to Solved upstream on the Phabricator (Upstream) board.

This should be resolved upstream by https://secure.phabricator.com/D20695.

Aug 2 2019, 4:56 PM · Phabricator (2019-08-22), Upstream
epriestley moved T180666: Investigate or work on how to make Diffusion repositories deletable via web interface from Upstreamed to Feedback From Upstream on the Phabricator (Upstream) board.

The misleading messaging has been fixed upstream by https://secure.phabricator.com/D20694.

Aug 2 2019, 4:35 PM · Upstream, Phabricator (Upstream), Diffusion

Aug 1 2019

epriestley moved T127314: After last update Phabricator doesn't send email notifications when subscribing oneself from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.

This is expected: since https://secure.phabricator.com/D14853, we've explicitly hidden these stories from feed and mail under the rationale that they are universally uninteresting.

Aug 1 2019, 10:46 PM · Phabricator (Upstream), Upstream, Regression
epriestley moved T130881: Herald changes shown in user feed from Backlog to Upstreamed on the Phabricator (Upstream) board.

This is technically covered under the umbrella of https://secure.phabricator.com/T8952 upstream.

Aug 1 2019, 10:41 PM · Phabricator (2019-12-19), Upstream
epriestley moved T134673: Phabricator sometimes doesn't show the "[1] [2] [Next]" buttons for further Notification pages from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.

I suspect this was resolved by https://secure.phabricator.com/D20455, maybe?

Aug 1 2019, 10:35 PM · Upstream, Phabricator (Upstream)
epriestley moved T140826: Default dashboard editing is not convenient from Backlog to Solved upstream on the Phabricator (Upstream) board.

I think this was effectively resolved a while ago, there's a little edit icon next to the selected board now that lets you jump to the edit view:

Aug 1 2019, 10:31 PM · Upstream, Phabricator (Upstream)
epriestley moved T153324: Phabricator batch editor should support mass moving tasks to different sections of the workboard from Backlog to Solved upstream on the Phabricator (Upstream) board.

I think this was implemented some time ago ("Move tasks to column..." from the workboard column action dropdown).

Aug 1 2019, 10:26 PM · Phabricator (Upstream), Upstream
epriestley moved T168182: Phab admins should be able to delete files that belong to other users via the web interface from Backlog to Upstreamed on the Phabricator (Upstream) board.

Just bookkeeping -- this is upstream as https://secure.phabricator.com/T7593.

Aug 1 2019, 10:20 PM · Upstream, Phabricator (Upstream)
epriestley moved T166760: Usability: Image overlay looks like new page from Backlog to Upstreamed on the Phabricator (Upstream) board.

I'm not a big fan of how this currently looks/works, either, and generally agree with all the feedback here. There's no specific upstream task for fixing it (and there are a few related things I want to look at) but I intend to change how this interaction works the next time Files gets an update.

Aug 1 2019, 10:17 PM · Upstream, Phabricator (Upstream)
epriestley moved T177483: Horizontal scroll bar initially hidden for inline Pastes from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.

This is a bit old, but I can't reproduce it against the currently deployed version of Phabricator on this install in Safari, Chrome, or Firefox. Not sure if it got fixed upstream or the Paste changed or if I'm just doing something wrong.

Aug 1 2019, 10:11 PM · WMSE-Bug-Reporting-and-Translation-2017, Upstream, Phabricator (Upstream)
epriestley moved T180305: Support refs/meta/config branches in Diffusion from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.

Upstream, this is https://secure.phabricator.com/T11502.

Aug 1 2019, 10:09 PM · Upstream, Phabricator (Upstream), Diffusion
epriestley moved T180666: Investigate or work on how to make Diffusion repositories deletable via web interface from Backlog to Upstreamed on the Phabricator (Upstream) board.

This guidance is out of date and a bit misleading. I filed https://secure.phabricator.com/T13364 upstream to update it.

Aug 1 2019, 10:05 PM · Upstream, Phabricator (Upstream), Diffusion
epriestley moved T168061: Global Advanced search should support "any()" and "not()" functions in the "Tags" field, like Maniphest's Advanced Search does from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.
Aug 1 2019, 9:43 PM · Upstream, Phabricator (Upstream)
epriestley added a comment to T168061: Global Advanced search should support "any()" and "not()" functions in the "Tags" field, like Maniphest's Advanced Search does.

See also T190342 and T224082.

Aug 1 2019, 9:43 PM · Upstream, Phabricator (Upstream)
epriestley moved T197935: Multiple grep results in one line displayed incorrectly from Backlog to Upstreamed on the Phabricator (Upstream) board.

I noted this on https://secure.phabricator.com/T13339, which is not exactly adjacent but sort of has similar flavor and is somewhere in the pipeline.

Aug 1 2019, 7:56 PM · Phabricator (2019-08-22), Upstream
epriestley added a comment to T190342: In Phabricator's global search, tasks in a project's milestone are not found when searching in the parent project.

(To throw another one on the pile, T168061 is also closely related, I think. I'll add some details there shortly, none of these are exactly copies of the others even though there's some overlap and a lot of commonality in the root causes.)

Aug 1 2019, 7:51 PM · Phabricator (Upstream), Upstream
epriestley added a comment to T190342: In Phabricator's global search, tasks in a project's milestone are not found when searching in the parent project.

That's already how things are working right now -- this task ("Tags" working differently in Maniphest vs Global search) and T224082 (query term "X\Y" working differently in Maniphest vs Global search) are both because the Ferret and Elastic engines are doing different things.

Aug 1 2019, 7:48 PM · Phabricator (Upstream), Upstream
epriestley moved T190342: In Phabricator's global search, tasks in a project's milestone are not found when searching in the parent project from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.

I think this is largely similar to T224082: the Elastic engine does not resolve the "Tags" query constraint in the same way that the builtin (approximately, Ferret) engine does, so searching for "Project X" in Maniphest means "Project X, or any child of project X" under the Ferret engine, but means "Project X exactly" in global search under the Elastic engine.

Aug 1 2019, 7:43 PM · Phabricator (Upstream), Upstream
epriestley moved T198838: Turn off 'blame' by default on Diffusion from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.

Blame loads asynchronously, so my expectation is that it does not slow the loading of the contents of the page.

Aug 1 2019, 7:24 PM · Phabricator (Upstream), Upstream, Diffusion
epriestley moved T201231: Wikimedia Phabricator's "Developer Log In" should set the focus on username from Backlog to Feedback From Upstream on the Phabricator (Upstream) board.

This was changed upstream in https://secure.phabricator.com/D20122 so we automatically focus the first "Username" field on the login page.

Aug 1 2019, 7:14 PM · Phabricator (Upstream), Upstream
epriestley moved T228224: "Merge Duplicates"/"Edit Parent Tasks"/"Edit Subtasks" dialogs: Clicking on a task title closes the dialog instead of selecting the task from Upstreamed to Solved upstream on the Phabricator (Upstream) board.

This should be resolved by https://secure.phabricator.com/D20693.

Aug 1 2019, 7:07 PM · Phabricator (2019-08-22), Regression, Upstream
epriestley moved T228224: "Merge Duplicates"/"Edit Parent Tasks"/"Edit Subtasks" dialogs: Clicking on a task title closes the dialog instead of selecting the task from Backlog to Upstreamed on the Phabricator (Upstream) board.

I think I can reproduce this sometimes. I filed this upstream as https://secure.phabricator.com/T13363.

Aug 1 2019, 6:59 PM · Phabricator (2019-08-22), Regression, Upstream
epriestley moved T228847: "Unhandled Exception: Testing for capability "interact" on an object ("PhabricatorRepositoryCommit") which does not support that capability." trying to remove a comment from Backlog to Solved upstream on the Phabricator (Upstream) board.

I believe this upstream in https://secure.phabricator.com/D20648.

Aug 1 2019, 6:55 PM · Phabricator (2019-08-22), Upstream

Jul 18 2019

epriestley added a comment to T133073: Subscriber changes not reported by email if Herald also changes subscribers in the same action.

This is expected behavior, but not exactly desirable. See https://secure.phabricator.com/T8952 upstream for some context.

Jul 18 2019, 4:14 PM · Upstream, Phabricator (Upstream)
epriestley added a comment to T219978: Make phame cacheable.

I'm not sure what the purpose of the cookie is...

Jul 18 2019, 3:12 PM · SRE, Traffic, Phabricator

Jul 17 2019

epriestley added a comment to T228225: Video embeds, even of OGV files, no longer work.

Ah, good catch. Yeah, files.viewable-mime-types is likely the culprit here.

Jul 17 2019, 3:54 PM · serviceops-radar, Phabricator
epriestley added a comment to T228225: Video embeds, even of OGV files, no longer work.

One of these is detecting as MIME type video/ogg; one as application/ogg. The files.video-mime-types configuration option in Phabricator includes both of these MIME types by default, but it may have been adjusted on this install to include only one. If so, a simple remedy might be to add application/ogg to files.video-mime-types, if there isn't some reason that it was removed/disabled and I'm guessing right about what's going on here. Locally, with the default configuration, this file embeds with video player controls for me:

Jul 17 2019, 2:55 PM · serviceops-radar, Phabricator

Jul 15 2019

epriestley added a comment to T227267: Permission to edit Forms No. 31, 32 and 33 for MarcoAurelio.

My expectation is that you need "Can Configure Application" on the Maniphest Application to edit Maniphest forms, and so on:

Jul 15 2019, 3:57 PM · Phabricator
epriestley added a comment to T218450: Exception when accessing to a Phabricator mock: "Attempting to add more metadata after metadata has been locked.".

This is linked elsewhere in connected tasks already, but I believe the upstream change in https://secure.phabricator.com/D20647 should fix this.

Jul 15 2019, 3:16 PM · Phabricator (Upstream), Upstream
epriestley moved T218450: Exception when accessing to a Phabricator mock: "Attempting to add more metadata after metadata has been locked." from Backlog to Solved upstream on the Phabricator (Upstream) board.
Jul 15 2019, 3:15 PM · Phabricator (Upstream), Upstream
epriestley edited projects for T218450: Exception when accessing to a Phabricator mock: "Attempting to add more metadata after metadata has been locked.", added: Phabricator (Upstream); removed Phabricator.
Jul 15 2019, 3:15 PM · Phabricator (Upstream), Upstream
epriestley added a comment to T223926: Phabricator login page does not show Welcome text / "Click button below" text anymore.

I think AuthCustomize MessagesLogin Screen Instructions should now let you configure this. I expect this approach should prove more stable than the older approaches.

Jul 15 2019, 3:14 PM · Developer-Advocacy (Jul-Sep 2019), Regression, Phabricator
epriestley added a comment to T224082: No results for specific string in Global Phab Search, while Advanced Search lists expected results (due to ElasticSearch for Global Search vs Ferret for Maniphest Search)?.

I believe this install is currently configured to use ElasticSearch for global search. Search in other interfaces (including Maniphest advanced search) is powered by Phabricator's builtin engine, "Ferret".

Jul 15 2019, 3:10 PM · Phabricator (2020-01-23)
epriestley added a comment to T227300: Document workboard column triggers.

Triggers currently only activate when a task card is dropped into a column with triggers (see this comment for details). They don't impose a global performance cost like Herald, and act on behalf of the user moving the card.

Jul 15 2019, 2:39 PM · Documentation, Phabricator

Jul 14 2019

epriestley moved T227963: Active Bot usernames are struckout in search suggestions, like disabled accounts from Backlog to Upstreamed on the Phabricator (Upstream) board.

I've filed this upstream in https://secure.phabricator.com/T13340. See that task for more details.

Jul 14 2019, 3:12 PM · Upstream, Phabricator (Upstream)

Jul 10 2019

epriestley moved T227519: "Unhandled Exception: Call to undefined method PhutilDOMNode::setRawContent() when trying to access several tasks from Backlog to Solved upstream on the Phabricator (Upstream) board.

This should be resolved upstream by https://secure.phabricator.com/D20644. The two changes noted above were similar, but didn't completely resolve this.

Jul 10 2019, 5:37 PM · Regression, Upstream, Phabricator (Upstream)

Jul 2 2019

epriestley moved T220585: "Move Tasks to Column..." opens dialogue for moving to project from Upstreamed to Solved upstream on the Phabricator (Upstream) board.

I think this will be substantially improved by the upstream change in https://secure.phabricator.com/D20636, which separates these actions:

Jul 2 2019, 4:12 PM · Phabricator (2019-08-22), Upstream, WMSE-Bug-Reporting-and-Translation-2019

Jun 29 2019

epriestley moved T226249: Cannot close "Custom Policy" dialog window when viewing policy of an OAuth application; no "Close" button displayed from Backlog to Solved upstream on the Phabricator (Upstream) board.

Thanks, this should be resolved upstream by https://secure.phabricator.com/D20624.

Jun 29 2019, 4:25 PM · Phabricator (2019-08-22), Upstream

Jun 6 2019

epriestley moved T220897: "Choose subtype" box does not disappear after choosing an option when creating new subtask with "Persistent Chat" option in Conpherence enabled from Upstreamed to Solved upstream on the Phabricator (Upstream) board.
Jun 6 2019, 2:25 AM · Phabricator (2019-07-03), Upstream