Change #1051362 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Updated README to reflect unmaintained status.

https://gerrit.wikimedia.org/r/1051362

I am new to this, apologies for any mistake. If somebody can look into, this. I think its not assigned for review to the proper maintainers. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LiquidThreads/+/1051362

Change #1051362 had a related patch set uploaded (by Agamyasamuel; author: Agamyasamuel):

[mediawiki/extensions/LiquidThreads@master] Updated README to ureflect Umaintained sSatus.

https://gerrit.wikimedia.org/r/1051362

Only use other than ReleaseNotes is:

					// Old code (which was used with the AbortMove hook, which
					// no longer exists in core):
					//$error .= wfMessage( 'spamregex-move' )->parse() . wfMessage( 'word_separator' )->escaped();

While I don't like the practice of commenting out code instead of deleting it this looks resolved

Thank you for tagging this task with good first task for Wikimedia newcomers!

Change #1037440 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Use expression builder to replace addQuotes

https://gerrit.wikimedia.org/r/1037440

Change #1037440 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] Use expression builder to replace addQuotes

https://gerrit.wikimedia.org/r/1037440

Mentioned in SAL (#wikimedia-operations) [2024-05-22T08:16:29Z] <hashar@deploy1002> Finished scap: Backport for [[gerrit:1034182|Fix fatal error due to missing signature on very old comments (T365495)]] (duration: 16m 27s)

I have deployed the fix this morning and confirmed the fix while doing the deployment. Thank you @matmarex!

Mentioned in SAL (#wikimedia-operations) [2024-05-22T08:02:38Z] <hashar@deploy1002> jforrester and hashar: Backport for [[gerrit:1034182|Fix fatal error due to missing signature on very old comments (T365495)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-22T08:00:01Z] <hashar@deploy1002> Started scap: Backport for [[gerrit:1034182|Fix fatal error due to missing signature on very old comments (T365495)]]

Change #1034182 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@wmf/1.43.0-wmf.6] Fix fatal error due to missing signature on very old comments

https://gerrit.wikimedia.org/r/1034182

Change #1034182 had a related patch set uploaded (by Jforrester; author: Bartosz Dziewoński):

[mediawiki/extensions/LiquidThreads@wmf/1.43.0-wmf.6] Fix fatal error due to missing signature on very old comments

https://gerrit.wikimedia.org/r/1034182

Change #1034554 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Fix fatal error due to missing signature on very old comments

https://gerrit.wikimedia.org/r/1034554

This probably only affects comments posted before rELQTcfbcd544b3e7: LiquidThreads (SCHEMA CHANGE): Make signatures a per-post affair, defaulting to… (2009), and seemingly only when viewing the topic history. I don't think it's a release blocker.

Change #1034554 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/LiquidThreads@master] Fix fatal error due to missing signature on very old comments

https://gerrit.wikimedia.org/r/1034554

If it seems like it can't happen, it's probably unserialized objects… yup.

It seems LQT Thread->signature is typed null|string but its constructor implies that this does not survive past the constructor, with a lzy fallback to a default:

Change #1026115 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026115

Change #1026115 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026115

Oups indeed, it looks like that is the same issue indeed. I should have searched Phabricator before creating the duplicate.