This tag is used for production errors that don't have a documented steward or owner. (mw:Maintainers)
Logical parent: Wikimedia-production-error.
Project photo via @brennen Can of Spam on a log
This tag is used for production errors that don't have a documented steward or owner. (mw:Maintainers)
Logical parent: Wikimedia-production-error.
Project photo via @brennen Can of Spam on a log
Short spike after 1.43.0-wmf.13 deployment around Jul 11, 2024 @ 08:30:00.000, again on strategywiki only just like dup T360110.
Looking at the actorid on idwiki, there was a rename of the actor on the day of this task, so the task is involved in rename.
Uploads have been going much better today, thank you to whoever fixed this. :-)
Also getting errors while uploading:
I am currently again experiencing lots of different error messages during file upload.
Still occurring
Appears with stack trace: (*at VideoJsResolutionSwitcherPlugin.chooseSrc*)
Noting this still shows up in 1.43.0-wmf.9.
Error is no longer present in the logs
We ran into the same problem in T315510: Start maintenance script to backfill talk page comment database, and I tried to look into it. Some observations:
Mentioned in SAL (#wikimedia-operations) [2024-05-22T08:16:29Z] <hashar@deploy1002> Finished scap: Backport for [[gerrit:1034182|Fix fatal error due to missing signature on very old comments (T365495)]] (duration: 16m 27s)
I have deployed the fix this morning and confirmed the fix while doing the deployment. Thank you @matmarex!
Mentioned in SAL (#wikimedia-operations) [2024-05-22T08:02:38Z] <hashar@deploy1002> jforrester and hashar: Backport for [[gerrit:1034182|Fix fatal error due to missing signature on very old comments (T365495)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-05-22T08:00:01Z] <hashar@deploy1002> Started scap: Backport for [[gerrit:1034182|Fix fatal error due to missing signature on very old comments (T365495)]]
Change #1034182 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@wmf/1.43.0-wmf.6] Fix fatal error due to missing signature on very old comments
Change #1034182 had a related patch set uploaded (by Jforrester; author: Bartosz Dziewoński):
[mediawiki/extensions/LiquidThreads@wmf/1.43.0-wmf.6] Fix fatal error due to missing signature on very old comments
Change #1034554 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Fix fatal error due to missing signature on very old comments
This probably only affects comments posted before rELQTcfbcd544b3e7: LiquidThreads (SCHEMA CHANGE): Make signatures a per-post affair, defaulting to… (2009), and seemingly only when viewing the topic history. I don't think it's a release blocker.
Change #1034554 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/LiquidThreads@master] Fix fatal error due to missing signature on very old comments
If it seems like it can't happen, it's probably unserialized objects… yup.
It seems LQT Thread->signature is typed null|string but its constructor implies that this does not survive past the constructor, with a lzy fallback to a default:
@Ladsgroup: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!
@daniel: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!
My idea would have been to wait a week, but I think it is already pretty clear that this error should be fixed for good:
Anything left to do here?
Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:45:48Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1029564|specials: Fix "include templates" query builder for Special:Export (T364554)]], [[gerrit:rOMWC103030846065|ArticleTarget: Fix return of getVisualDiffGeneratorPromise (T364635)]] (duration: 16m 04s)
Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:32:09Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 umherirrender and lucaswerkmeister-wmde and matmarex: Backport for [[gerrit:1029564|specials: Fix "include templates" query builder for Special:Export (T364554)]], [[gerrit:rOMWC103030846065|ArticleTarget: Fix return of getVisualDiffGeneratorPromise (T364635)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:29:44Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap: Backport for [[gerrit:1029564|specials: Fix "include templates" query builder for Special:Export (T364554)]], [[gerrit:rOMWC103030846065|ArticleTarget: Fix return of getVisualDiffGeneratorPromise (T364635)]]
Change #1029564 merged by jenkins-bot:
[mediawiki/core@wmf/1.43.0-wmf.4] specials: Fix "include templates" query builder for Special:Export