core: add clearStorageTypes option
#15508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
question for reviewer: I don't like the name |
adamraine
reviewed
Oct 3, 2023
adamraine
reviewed
Oct 19, 2023
adamraine
reviewed
Oct 19, 2023
|
You may need to run the following command to fix CI: The unit test failures appear to be unrelated which I'll work on separately (#15553). |
vegerot
changed the title
clearStorageTypes option
adamraine
approved these changes
Oct 23, 2023
Summary: This adds a new option to the config to allow users to specify which storage types to clear when resetting storage for a URL. This is useful for testing scenarios where you want to clear all storage except for a specific type. Test plan: - Added a few unit tests to make sure the option works as expected
adamraine
changed the title
clearStorageTypes optionclearStorageTypes option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a new option to the config to allow users to specify which storage types to clear when resetting storage for a URL. This is useful for testing scenarios where you want to clear all storage except for a specific type.
Test plan:
Related Issues/PRs
closes #15506