Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header validator inconsistent with spec re size checks #1321

Closed
apasel422 opened this issue Jun 6, 2024 · 0 comments · Fixed by #1333
Closed

Header validator inconsistent with spec re size checks #1321

apasel422 opened this issue Jun 6, 2024 · 0 comments · Fixed by #1333
Assignees
@apasel422
Labels
bug Something isn't working headers-validator

Comments

@apasel422
Copy link
Collaborator

Per https://wicg.github.io/attribution-reporting-api/#parse-attribution-destinations, the size of the destination field is supposed to be checked after URL-to-site transformation and deduplication, but the validator checks the size of the JSON list itself, causing some registrations that would be allowed by the spec to be prohibited by the validator.

This also applies to filter_data values.
@apasel422 apasel422 self-assigned this Jun 6, 2024
@apasel422 apasel422 added the bug Something isn't working label Jun 6, 2024
apasel422 added a commit to apasel422/attribution-reporting-api that referenced this issue Jun 6, 2024
@apasel422
Make length checks explicit for arrays and sets
b8ba564 
In preparation for addressing WICG#1321.
@apasel422 apasel422 mentioned this issue Jun 6, 2024
Merged
apasel422 added a commit that referenced this issue Jun 6, 2024
@apasel422
Make length checks explicit for arrays and sets (#1324)
fe6ed27 
In preparation for addressing #1321.
@WICG WICG deleted a comment from gauche-torres Jun 9, 2024
apasel422 added a commit to apasel422/attribution-reporting-api that referenced this issue Jun 11, 2024
@apasel422
Add tests for source-side set sizes
7d0e61f 
In preparation for addressing WICG#1321.
@apasel422 apasel422 mentioned this issue Jun 11, 2024
Merged
apasel422 added a commit that referenced this issue Jun 11, 2024
@apasel422
Add tests for source-side set sizes (#1332)
29dcd98 
In preparation for addressing #1321.
apasel422 added a commit to apasel422/attribution-reporting-api that referenced this issue Jun 11, 2024
@apasel422
Check size of sets after deduplication instead of before
ceebf99 
To match the spec.

Fixes WICG#1321.
@apasel422 apasel422 mentioned this issue Jun 11, 2024
Merged
apasel422 added a commit to apasel422/attribution-reporting-api that referenced this issue Jun 18, 2024
@apasel422
Check size of sets after deduplication instead of before
9b9bb40 
To match the spec.

Fixes WICG#1321.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apasel422 apasel422

Labels
bug Something isn't working headers-validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check size of sets after deduplication instead of before apasel422/attribution-reporting-api
1 participant
@apasel422