Update Validation of MediaAlly.php Trait #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was giving an error on `$request->file` I just make it to validate whether the given parameter is actually an instance of the upload file or not.
|
@cw-alihyder What error was it giving? |
|
it's not letting the user go to next keep throwing the Exception even if it's a file Instance. |
|
So how does your PR fix it? @cw-alihyder |
|
now my PR fixes this by validating whether the param is actually an instance of |
unicodeveloper
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was giving an error on
$request->fileI just make it to validate whether the given parameter is actually an instance of the upload file or not.