-
Benachrichtigungen
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Description Adds the ability to customize the Video Player's poster in a few different ways. 1. String - Public ID or Remote URL ``` poster="publicId" poster="https://...com/image.jpg ``` 2. Object - Customizing the poster image auto-generated from the video ``` poster={{ tint: 'equalize:80:blue:blueviolet' }} ``` This uses the same API as getCldVideoUrl with a format of image to generate an image from the video. Note: this is very similar to getCldImageUrl, only the asset type is video and some options may be slightly different depending on what is supported on the video asset type. It's for the most part the same API as getCldImageUrl. 3. Object - Custom poster image using a different Cloudinary Public ID ``` poster={{ src: 'publicId', tint: 'equalize:80:blue:blueviolet' }} ``` Same as #2, only this is explicitly an image and uses getCldImageUrl Also: - Adds a new getCldVideoUrl helper which supports the above work - Marks in the code deprecation of types that don't actually do anything for the helper functions, will remove on next major in case for some reason they're being imported - Updates helper function types to use the appropriate helper-specific types intended to future-proof usage - Cleaned up the Examples page for the Player a little bit to be easier to consume ## Issue Ticket Number Fixes #322 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
- Loading branch information
1 parent
086733d
commit 077abcf
Showing
15 changed files
with
433 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"basic-usage": "Basic Usage", | ||
"configuration": "Configuration", | ||
"examples": "Examples" | ||
} |
Oops, something went wrong.
077abcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
next-cloudinary – ./
next-cloudinary-git-main-cloudinarydevx.vercel.app
next-cloudinary.vercel.app
next.cloudinary.dev
next-cloudinary-cloudinarydevx.vercel.app
next-cloudinary.spacejelly.dev