Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot open Signed UploadWidget #158

Closed
mcoeur opened this issue Mar 21, 2023 · 3 comments · Fixed by #160
Closed

[Bug] Cannot open Signed UploadWidget #158

mcoeur opened this issue Mar 21, 2023 · 3 comments · Fixed by #160
Labels

Kommentare

@mcoeur
Copy link

mcoeur commented Mar 21, 2023

Bug Report

Describe the bug

When clicking on the button to open the UploadWidget, nothing happens and an error triggers : p.current.open is not a function

Is this a regression?

I don't know, this is my first time using this package

Steps To Reproduce the error

  1. Create a <CldUploadWidget /> component, just like mentioned in the documentation
  2. Click the "Upload an Image" button

Expected behaviour

CodeSandbox or Live Example of Bug

The bug is actually present on the official documentation page :
https://next-cloudinary.spacejelly.dev/components/clduploadwidget/examples

Screenshot or Video Recording

Video recording

Your environment

  • OS: MacOS
  • Node version: 16.13.1
  • Npm version: 8.1.2
  • Browser name and version: Chrome - 111.0.5563.64
@colbyfayock
Copy link
Collaborator

hey thanks for the bug report. turns out it wasn't quite a bug, i was missing my api key on the docs deployment 🤦

that said i did have an optional chaining fix to the right spot to avoid the error you were seeing and added a warning for people like me who forgot to add that :)

not sure if you're just reporting this from the docs or from your own usage but that should address the issue, let me know if you're seeing anything else after it's merged/deployed

colbyfayock added a commit that referenced this issue Mar 22, 2023
# Description

Minor changes to help avoid errors with the Signed upload widget:
* fixed optional chaining to make sense for method invocation on a ref
* Added a warning for missing API Key

## Issue Ticket Number

Fixes #158 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> -->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket
for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the
same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue Mar 22, 2023
## [4.0.1](v4.0.0...v4.0.1) (2023-03-22)

### Bug Fixes

* Help reduce Signed Upload errors ([#160](#160)) ([d323e33](d323e33)), closes [#158](#158)
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

cham74 added a commit to cham74/next-image-delivery that referenced this issue Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants