-
Benachrichtigungen
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Overlay for Videos #186
Kommentare
hey @lelouchB check out this second example: https://next-cloudinary-gsjwm4f2y-colbyfayock.vercel.app/components/cldvideoplayer/examples thats what you had in mind right? I'm using the id like to eventually build a better API, like have an overlays= prop like CldImage, but for now, i wanted to get something together as i want to put more thought around that gonna wait to get your eyes on this before i merge it :) |
That's exactly what I needed |
# Description Adds the `transformation` property to the player to provide effects. This allows a variety of options but specifically for the Issue, allows overlays, such as watermarks. ## Issue Ticket Number Fixes #186 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
🎉 This issue has been resolved in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [4.7.0](cloudinary-community/next-cloudinary@v4.6.0...v4.7.0) (2023-04-27) ### Features * Adding transformation property to player ([#188](cloudinary-community/next-cloudinary#188)) ([5916598](cloudinary-community/next-cloudinary@5916598)), closes [#186](cloudinary-community/next-cloudinary#186)
Feature Request
At the moment, we can't add an overlay to CldVideoPlayer
Describe the solution you'd like
It would be nice to have overlays/watermarks to videos
The text was updated successfully, but these errors were encountered: