Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Overlay for Videos #186

Closed
lelouchB opened this issue Apr 27, 2023 · 3 comments · Fixed by #188
Closed

[Feature] Overlay for Videos #186

lelouchB opened this issue Apr 27, 2023 · 3 comments · Fixed by #188
Labels

Kommentare

@lelouchB
Copy link

Feature Request

At the moment, we can't add an overlay to CldVideoPlayer

Describe the solution you'd like

It would be nice to have overlays/watermarks to videos

@colbyfayock
Copy link
Collaborator

colbyfayock commented Apr 27, 2023

hey @lelouchB check out this second example:

https://next-cloudinary-gsjwm4f2y-colbyfayock.vercel.app/components/cldvideoplayer/examples

#188

thats what you had in mind right?

I'm using the transformation parameter for now and just passing it through

id like to eventually build a better API, like have an overlays= prop like CldImage, but for now, i wanted to get something together as i want to put more thought around that

gonna wait to get your eyes on this before i merge it :)

@lelouchB
Copy link
Author

That's exactly what I needed
Thanks so much :)

colbyfayock added a commit that referenced this issue Apr 27, 2023
# Description

Adds the `transformation` property to the player to provide effects.

This allows a variety of options but specifically for the Issue, allows
overlays, such as watermarks.

## Issue Ticket Number

Fixes #186 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> -->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket
for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the
same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue Apr 27, 2023
# [4.7.0](v4.6.0...v4.7.0) (2023-04-27)

### Features

* Adding transformation property to player ([#188](#188)) ([5916598](5916598)), closes [#186](#186)
@github-actions
Copy link

🎉 This issue has been resolved in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

cham74 added a commit to cham74/next-image-delivery that referenced this issue Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants