Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add the ability to specify languages for label localization #384

Closed
colbyfayock opened this issue Dec 21, 2023 · 1 comment · Fixed by #385
Closed

[Feature] Add the ability to specify languages for label localization #384

colbyfayock opened this issue Dec 21, 2023 · 1 comment · Fixed by #385
Labels
released

Kommentare

@colbyfayock
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe.

Example: https://codesandbox.io/p/sandbox/cld-video-i18n-ehlu8?file=%2Findex.html

Video.js JSON examples: https://github.com/videojs/video.js/tree/main/lang

Describe the solution you'd like

language="es"
languages={{
  es: {...}
}}
@colbyfayock colbyfayock mentioned this issue Dec 21, 2023
Merged
12 tasks
colbyfayock added a commit that referenced this issue Dec 21, 2023
@colbyfayock
feat: CldVideoPlayer Localization (#385)
3845399 
# Description

Exposes the language and languages prop to provide the ability to add
localization options to CldVideoPlayer

## Issue Ticket Number

Fixes #384 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> -->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket
for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the
same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue Dec 21, 2023
@semantic-release-bot
chore(release): 5.15.0 [skip ci]
c5338b2 
# [5.15.0](v5.14.1...v5.15.0) (2023-12-21)

### Features

* CldVideoPlayer Localization ([#385](#385)) ([3845399](3845399)), closes [#384](#384)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

cham74 added a commit to cham74/next-image-delivery that referenced this issue Dec 23, 2023
@cham74
chore(release): 5.15.0 [skip ci]
fd82fe6 
# [5.15.0](cloudinary-community/next-cloudinary@v5.14.1...v5.15.0) (2023-12-21)

### Features

* CldVideoPlayer Localization ([#385](cloudinary-community/next-cloudinary#385)) ([3845399](cloudinary-community/next-cloudinary@3845399)), closes [#384](cloudinary-community/next-cloudinary#384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CldVideoPlayer Localization cloudinary-community/next-cloudinary
1 participant
@colbyfayock